fix(classify-hardware): guard non-numeric and negative bounds in ram and vram parsing - #6084
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 20, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/classify-hardware.sh,--vram-mband--ram-mbCLI arguments were converted directly in Python usingint(float(sys.argv[...] or 0)). When upstream hardware detection probes fail to detect a GPU or memory module (or return non-numeric placeholders like"None","N/A", or"null"), Python raised an unhandledValueError: could not convert string to float: 'None'. This aborted hardware classification, causing installer and preflight routines to crash instead of falling back to default CPU profile recommendations.This change introduces a safe numeric parsing helper
_safe_mbthat catchesValueErrorandTypeError, safely defaults invalid or empty inputs to0, and clamps negative values to non-negative bounds (max(0, ...)). All hardware matching logic, overlay mappings, and output JSON schemas remain unchanged.Validation
classify-hardware.sh --vram-mb None --ram-mb N/AraisedValueError: could not convert string to float: 'None'and exited with status 1.ods/tests/test_classify_hardware_numeric_bounds.pyvalidates that non-numeric strings ("None","N/A","null"), negative numbers, and float representations execute cleanly with exit code 0 and emit valid hardware classification recommendations.test_classify_hardware_numeric_bounds.pypasses cleanly (exit code 0). Wired into Linux CI workflow under Manifest Compatibility Checks.Overlap check
amd-topo.sh.detect-hardware.sh.ods-doctor.sh.gpu-database.jsonor overlay resolution logic.Risk / AI disclosure
AI-assisted investigation, implementation, and test regressions. This strengthens numeric CLI argument parsing in classify-hardware.sh. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6076, #6077, #6078, #6079, #6080, #6081, #6082, and #6083 at HEAD without conflicts. Production and test diffs passed together; hardware classification and manifest checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.