fix(classify-hardware): reject missing option arguments in classify-hardware.sh

[vaibhavsrv]

Why this matters

In ods/scripts/classify-hardware.sh, CLI options that take a value (--platform-id, --gpu-vendor, --memory-type, --vram-mb, --device-id, --gpu-name, --cpu-name, --ram-mb, and --db) executed shift 2 unconditionally. When an option was supplied at the end of the argument list without a corresponding value, running shift 2 when $# < 2 triggered an unhandled shell exit under set -e without writing any diagnostic message to stderr. Furthermore, passing an option without a value before another option silently assigned the next option flag as its value.

This change introduces pre-shift argument count validation for options requiring an argument. If an option value is missing ($# < 2), the script immediately writes an informative diagnostic to standard error and exits with code 1. Existing database lookup, platform mapping, and classification defaults remain intact.

Validation

• Baseline reproduction: Executing bash ods/scripts/classify-hardware.sh --device-id on the unpatched script failed with an unhandled exit 1 and an empty standard error.
• Post-fix verification: Running ods/tests/test_classify_hardware_option_args.py validates that all value-requiring options fail cleanly with exit code 1 and emit ERROR: <option> requires an argument on stderr, while valid invocations (both JSON and --env modes) succeed with exit code 0.
• Telemetry: Hardware classification suites: 2 passed. New-test PyCompile, ShellCheck, and diff checks pass; new regressions wired into Linux CI.

Overlap check

• fix(classify-hardware): guard non-numeric and negative bounds in ram and vram parsing #6084: Addressed non-numeric parsing bounds for RAM and VRAM in classify-hardware.sh.
• fix(classify-hardware): guard vram and memory float parsing in classify-hardware.sh #5451: Addressed hardware classifier fallback handling.
• fix(amd-topo): format vram with LC_ALL=C for decimal-comma locales #6076: Addressed locale-aware decimal formatting in amd-topo.sh.
• Does not modify any entry in gpu-database.json or overlay resolution logic.

Risk / AI disclosure

AI-assisted investigation, implementation and CLI regressions. This strengthens CLI option validation in classify-hardware.sh without modifying classification heuristics or database mappings. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.

Follow-up integration evidence

Composed with #6344 at 5804280 without conflicts. Production and test diffs passed together; hardware classification and manifest checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.

[Lightheartdevs]

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.