fix(hermes): enforce trailing newline on patched hermes config - #6085
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 20, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/patch-hermes-config.py,patch_config()conditioned adding a final newline on whether the unpatched original file already possessed one (trailing_newline = original.endswith("\n")). When migrating older template files or user-provided Hermes configs that omitted a terminating newline, the patch utility persisted the missing-newline state. This violated POSIX newline standards and caused YAML parsers and linting tools to flag\ No newline at end of file.This change unconditionally appends a terminating newline (
\n) to serialized YAML configs on write. All section preservation logic, model overrides, provider timeouts, and auxiliary configuration keys remain untouched.Validation
ods/tests/test_patch_hermes_config_trailing_newline.pyvalidates that patching a config lacking a trailing newline outputs valid YAML ending with\n, applies specified model overrides, and remains idempotent on subsequent runs.test_patch_hermes_config_trailing_newline.pypasses cleanly (exit code 0). Wired into Linux CI workflow under Hermes Slash Worker Prune Tests.Overlap check
patch-hermes-config.py.classify-hardware.sh.Risk / AI disclosure
AI-assisted investigation, implementation, and test regressions. This standardizes POSIX trailing newline formatting for patched Hermes YAML files. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6076, #6077, #6078, #6079, #6080, #6081, #6082, #6083, and #6084 at HEAD without conflicts. Production and test diffs passed together; Hermes worker and configuration checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.