Repository navigation
fix(healthcheck): guard missing port delimiter in _parse_host_port - #6079
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 20, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/healthcheck.py,_parse_host_port()parses TCP host and port targets. When called directly with a target missing a colon delimiter (such as"localhost"or"127.0.0.1"without port, or strings with untrimmed whitespace),raw.rsplit(":", 1)unpacks into a single element, raising an unhandledValueError: not enough values to unpack (expected 2, got 1)rather than a descriptive domain error.This change strips surrounding whitespace and explicitly asserts
":" in rawbefore splitting, raisingValueError("missing port delimiter ':' in target")if no port delimiter is present. Valid hostname and IPv6 bracketed targets remain untouched.Validation
_parse_host_port("localhost")raised unhandled unpackingValueError: not enough values to unpack (expected 2, got 1).ods/tests/test_healthcheck_host_port_delimiter.pyverifies that targets without a colon raiseValueError("missing port delimiter ':' in target"), and targets with surrounding whitespace are cleanly trimmed and parsed.test_healthcheck_host_port_delimiter.pypasses cleanly (exit code 0). Wired into Linux CI workflow under healthcheck tests.Overlap check
healthcheck.py. This change hardens host:port delimiter presence before splitting._parse_target, timeout bounds, and HTTP scheme checking. This PR operates strictly on_parse_host_port.Risk / AI disclosure
AI-assisted investigation, implementation, and test regressions. This improves input validation and error clarity for target parsing. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5875, #5950, #5951, #6076, #6077, and #6078 at HEAD without conflicts. Production and test diffs passed together; healthcheck IPv6 and redirect policy suites remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.