Repository navigation
fix(pixel-chat): reject empty or unstripped credential in owner_namespace - #5808
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
This was referenced Sep 19, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_chat_results.py,owner_namespace(credential)hashed input credentials without validating non-empty, trimmed strings. Consequently, empty strings or credentials with trailing whitespace were hashed into valid 64-character hex namespaces, creating split result stores for the same logical owner.This surgical fix verifies
credential and credential == credential.strip(), raisingValueError("invalid-owner-credential")on malformed credentials.Validation
owner_namespace("")andowner_namespace(" owner ")produced hashes without error on baseline.ValueError("invalid-owner-credential").pixel-chat suite: 3 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5745 guarded project receipts; zero overlap with chat result namespace hashing.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Guards owner isolation namespaces against credential padding. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.