Skip to content

fix(pixel-chat): validate sequence boundary type and range in ChatResultStore chunks - #5997

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-chat-results-chunks-after-type
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-chat-results-chunks-after-type

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_chat_results.py, chunks(self, key, after=-1) passes after directly to the SQLite query sequence > ?. When string arguments (e.g. from query parameters) or negative numbers below -1 are passed, SQLite comparison semantics can cause unexpected chunk exclusion or type coercion errors.

This surgical fix validates type(after) is int and after >= -1 in chunks, raising TypeError("after must be an integer >= -1").

Validation

  • Baseline reproduction: verified that store.chunks(key, after="0") passed through without type checking on baseline.
  • Post-fix behavior: properly raises TypeError("after must be an integer >= -1").
  • Telemetry: pixel-chat suite: 1 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5808 checked owner_namespace; zero overlap with chunk query sequence paging bounds.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Enforces paging parameter validation on chunk retrieval. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 6a408cc85 without conflicts. CI and unit checks pass.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants