Repository navigation
fix(pixel-chat): validate 3-element tuple key structure in ChatResultStore reserve - #5985
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_chat_results.py,ChatResultStore.reserve(key, fingerprint)unpackskeydirectly into SQL queries expecting exactly 3 parameters(owner, chat, attempt). Passing a key with fewer or more elements causessqlite3.ProgrammingError: Incorrect number of bindings suppliedto crash the transaction.This surgical fix validates that
keyis a 3-element tuple or list of non-empty strings before querying SQLite, raisingValueError("Invalid attempt key").Validation
reserve(("a", "b"), "fp")raised unhandledsqlite3.ProgrammingErroron baseline.ValueError("Invalid attempt key").pixel-chat suite: 1 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5808 checked owner_namespace; zero overlap with result store key validation.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Enforces input validation on chat attempt reservation. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
6a408cc85without conflicts. CI and unit checks pass.