Skip to content

fix(pixel-chat): validate attempt key structure in ChatResultStore finish - #5986

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-chat-results-finish-key-validation
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-chat-results-finish-key-validation

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_chat_results.py, finish(self, key, state) checks state validity but binds (*key,) into SQL updates without validating key structure. Malformed key tuples with fewer than 3 elements trigger raw SQLite binding exceptions.

This surgical fix validates that key is a 3-element tuple or list of non-empty strings before database operations, raising ValueError("Invalid attempt key").

Validation

  • Baseline reproduction: verified that finish(("a",), "complete") raised SQLite binding error on baseline.
  • Post-fix behavior: properly raises ValueError("Invalid attempt key").
  • Telemetry: pixel-chat suite: 1 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5808 checked owner_namespace; zero overlap with result finish validation.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Enforces key validation on receipt finalization. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 6a408cc85 without conflicts. CI and unit checks pass.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants