fix(pixel-teams): handle split multibyte utf8 sequences in sse stream decoding - #5722
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
This was referenced Sep 18, 2026
Closed
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/routers/pixel_teams.py, the_runcoroutine decoded SSE chunks fromresponse.body_iteratorusingbuffered += chunk.decode("utf-8") if isinstance(chunk, bytes) else chunk. When a multi-byte UTF-8 character (such as emoji, symbols, or localized characters) is split across network TCP or chunk boundaries by the upstream inference stream, callingchunk.decode("utf-8")on an incomplete byte slice raises an unhandledUnicodeDecodeError, terminating the team worker task abruptly.This surgical fix introduces Python's standard
codecs.getincrementaldecoder("utf-8")()to buffer incomplete multi-byte sequences across chunk boundaries before appending decoded text to the line buffer.Validation
.decode("utf-8")on split chunkb'\xf0\x9f'raisesUnicodeDecodeError.pixel-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected live open/closed PRs. PR #5695 touched chat cancel; PR #5689 touched team history files. Zero overlap with SSE streaming chunk decoding in
pixel_teams.py.Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Uses Python's standard incremental decoder without changing downstream SSE parsing contracts. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. Unit and CI checks pass.