Skip to content

fix(pixel-agent-teams): validate team_id hex format in worker constructor - #5742

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-worker-team-id-hex
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-worker-team-id-hex

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_agent_teams.py, worker(team_id, index, role) constructs chat_id via f"team-{team_id}-{index}" without verifying that team_id conforms to the canonical 32-character hexadecimal UUID format used throughout the agent teams subsystem. Malformed or unvalidated team IDs generate invalid session keys and fail downstream router validations.

This surgical fix validates that team_id is a 32-character lowercase hex string (r"[a-f0-9]{32}"), raising ValueError on invalid values.

Validation

  • Baseline reproduction: verified that worker("invalid", 0, "builder") generated invalid chat_id on baseline.
  • Post-fix behavior: raises ValueError("team_id must be a 32-character hexadecimal string").
  • Telemetry: pixel-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5722 handled multibyte UTF-8 stream decoding; zero overlap with worker constructor.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Enforces team session identifier format. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 4fa6ad170 without conflicts. CI and unit checks pass.

…ctor

Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants