fix(pixel-agent-teams): guard non-string input type in planned_count resolution - #5741
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
…resolution Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_agent_teams.py,planned_count(text)performstext[:12000]within atryblock catching(ValueError, TypeError). However, passing a non-subscriptable object or non-string type still triggers aTypeErrorexception path instead of cleanly returningNoneimmediately.This surgical fix adds an explicit
if not isinstance(text, str): return Noneguard, ensuring deterministic return behavior without relying on exception handling for standard type checks.Validation
planned_count(None)raised and caughtTypeErrorinternally.Nonefor non-string types.pixel-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5722 handled multibyte UTF-8 SSE decoding in pixel-teams; zero overlap with
planned_countparser.Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Restricts input type handling in team count extraction. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.