Repository navigation
fix(pixel-agent-teams): reject duplicate options after whitespace stripping in questions - #5735
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
…ipping in questions Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_agent_teams.py,questions_valid(value)validates that question options contain no duplicates vialen(set(q["options"])) != len(q["options"]). However, options like["yes", "yes "]bypass this check because trailing spaces make raw strings distinct even though they collapse into identical values when presented or trimmed.This surgical fix compares
len({x.strip() for x in q["options"]})againstlen(q["options"]), ensuring options remain unique after whitespace normalization.Validation
["yes", "yes "]passedquestions_validon baseline.Falsewhen trimmed option strings collide.pixel-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5722 touched teams stream decoding; zero overlap with question validation logic.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Strengthens question option validation. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.