Skip to content

fix(pixel-agent-teams): reject duplicate options after whitespace stripping in questions - #5735

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-question-options-duplicates
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-question-options-duplicates

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_agent_teams.py, questions_valid(value) validates that question options contain no duplicates via len(set(q["options"])) != len(q["options"]). However, options like ["yes", "yes "] bypass this check because trailing spaces make raw strings distinct even though they collapse into identical values when presented or trimmed.

This surgical fix compares len({x.strip() for x in q["options"]}) against len(q["options"]), ensuring options remain unique after whitespace normalization.

Validation

  • Baseline reproduction: verified that ["yes", "yes "] passed questions_valid on baseline.
  • Post-fix behavior: returns False when trimmed option strings collide.
  • Telemetry: pixel-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5722 touched teams stream decoding; zero overlap with question validation logic.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Strengthens question option validation. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 4fa6ad170 without conflicts. CI and unit checks pass.

…ipping in questions

Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants