Repository navigation
Fade city developed ground into the terrain instead of a hard rim - #1999
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
Noisemaker111
enabled auto-merge
October 20, 2026 14:01
This was referenced Oct 20, 2026
Owner
Author
|
Generated by Claude Code |
Owner
Author
|
With the 20 s default from #2000 in place, Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember Command's hamlet ended in a hard, stair-stepped green polygon around the player's castle, cutting across the painted dirt.
shell/scene/CityRenderer.tsx: the developed-ground sheet carries per-vertex alpha that smoothsteps to 0 over its outer 9 m (FABRIC_FADE); material istransparent,depthWrite={false}. It drops the fixedFRINGE_COLORlerp, which only matched green terrain.MeshAccumulator.addColoredMeshremoved (its one caller now builds the RGBA geometry).changes/fabric-soft-edge.md.Root cause: the sheet stops wherever a 2.5 m cell's mean street distance passes
reach, so its rim follows the cell grid. Lerping to a fixed green only hid that on grass-coloured terrain.Verification
bun test packages/shell/src/scene— pass;bun --cwd=packages/shell run check-types— pass;ship:preflight— okshelldist swapped, 1280×720, same opening. Left is before, right is after:Generated by Claude Code