Skip to content

Draw gravel-lane crossings as gravel, not asphalt slabs - #1998

Merged
Noisemaker111 merged 7 commits into
betafrom
gravel-junctions
Oct 20, 2026
Merged

Noisemaker111 merged 7 commits into
betafrom
gravel-junctions

Conversation

@Noisemaker111

Copy link
Copy Markdown
Owner

Ember Command's unpaved "ruined hamlet" showed a near-black slab at every crossing of its gravel lanes.

  • shell/scene/cityJunctionSurface.ts (@internal): a crossing is gravel only when every street running through it is gravel; any paved street keeps it asphalt.
  • CityRenderer routes gravel crossings into the gravel mesh instead of the asphalt patches mesh. 4 tests; changes/gravel-junctions.md.

Root cause: the welded junction surfaces always went into patches (asphalt colour × wear tint), whatever the streets' surface. Found by ray-picking the slabs in the live scene: 161-vertex patches mesh, colour #3a3b3d.

Verification

  • bun test packages/shell/src/scene — 10 pass, 0 fail; check-types — pass; ship:preflight — ok
  • Ember Command with only shell dist swapped, 1280×720, same opening. Left is before, right is after:

gravel-junction-before-after


Generated by Claude Code

…changelog]

The first test loads the full shell bundle in real Chromium; on a loaded
CI runner it passes Bun's 5 s default and the remaining tests cascade.
It failed this way on #1995, #1996, #1998 and #1999 while passing on
beta and #1997.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw

Copy link
Copy Markdown
Owner Author

test failed in packages/shell/src/settingsBoundary.test.ts (5 failures after a 5 s hook timeout). This PR doesn't touch shell settings, and the same failure hit #1995, #1996 and #1999. I ported the fix from #2000 (20 s timeout for that browser test) and pushed.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
… [skip changelog]

After the settings boundary test got 20 s, the same runner timed out
hudInputBoundary and the Rapier slope test instead: whichever cold-start
browser/WASM suite runs first under load passes Bun's 5 s default. All
pass locally. Set the default for the CI test command; tests with their
own timeout keep it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
@Noisemaker111
Noisemaker111 merged commit 92cfd21 into beta Oct 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants