Repository navigation
Flag silent games in doctor - #1995
Merged
Merged
Conversation
Beacon Bastion, Brightway Park, Ember Command and Odd Orbit shipped with no sound at all while doctor reported nothing. Doctor now fails a game that declares no audio cues and never plays one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
Noisemaker111
enabled auto-merge
October 20, 2026 13:31
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
…changelog] The first test loads the full shell bundle in real Chromium; on a loaded CI runner it passes Bun's 5 s default and the remaining tests cascade. It failed this way on #1995, #1996, #1998 and #1999 while passing on beta and #1997. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
Owner
Author
|
Generated by Claude Code |
This was referenced Oct 20, 2026
… [skip changelog] After the settings boundary test got 20 s, the same runner timed out hudInputBoundary and the Rapier slope test instead: whichever cold-start browser/WASM suite runs first under load passes Bun's 5 s default. All pass locally. Set the default for the CI test command; tests with their own timeout keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four reference games (Beacon Bastion, Brightway Park, Ember Command, Odd Orbit) shipped with no sound at all, and
jgengine doctorreported nothing.jgengine/src/doctor.ts: new finding "game has sound (declares audio cues)" — passes whengame.config.tsdeclaresaudio:or anysrcscript callsctx.game.audio.play/loop; fix text points at proceduralSoundDefsynth cues (no asset files).audio.playclears it.changes/doctor-silent-game.md.Verification
bun test packages/jgengine/src/doctor.test.ts— 16 pass, 0 fail;check-types— pass;ship:preflight— okNo rendered surface changed.
Generated by Claude Code