Repository navigation
Anchor overhead-camera audio at the ground focus - #1996
Merged
Merged
Conversation
The listener followed the camera. RTS and top-down rigs sit 35-50 m up, past the default 24 m falloff, so positional build, combat and death cues were silent even at screen centre; Beacon and Brightway each widened falloff by hand to compensate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
Noisemaker111
enabled auto-merge
October 20, 2026 13:34
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
…changelog] The first test loads the full shell bundle in real Chromium; on a loaded CI runner it passes Bun's 5 s default and the remaining tests cascade. It failed this way on #1995, #1996, #1998 and #1999 while passing on beta and #1997. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
Owner
Author
|
Generated by Claude Code |
This was referenced Oct 20, 2026
… [skip changelog] After the settings boundary test got 20 s, the same runner timed out hudInputBoundary and the Rapier slope test instead: whichever cold-start browser/WASM suite runs first under load passes Bun's 5 s default. All pass locally. Set the default for the CI test command; tests with their own timeout keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwsemkhoUGyeQkdkKFmUmw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positional sound was silent in top-down and RTS games.
shell/audio/listenerAnchor.ts:groundFocusListenerputs the listener where the camera's view ray meets the ground (lifted 2 m, clamped to 400 m), or keeps the camera position when the view never reaches the ground.AudioListenertakesanchor;Shell3dPresentationpasses"ground"forrts/topDownrigs and"camera"otherwise.changes/audio-listener-ground-focus.md.Root cause: the listener tracked the camera, which these rigs hold 35–50 m above the play surface, beyond the 24 m default falloff. While adding sound to Beacon Bastion (topDown, height 38) and Brightway Park (rts), both agents independently widened
falloff.maxDistanceper sound to hear anything; Ember Command (rts, height 34) would have shipped silent world cues.Verification
bun test packages/shell/src/audio— 38 pass, 0 fail;bun --cwd=packages/shell run check-types— pass;ship:preflight— okresolveEmitterGain(distance(listener, emitter)), now measured from the ground focus.No rendered surface changed.
Generated by Claude Code