Repository navigation
Fix: Lay the page area out again when the appbar folds or shows - #190
Merged
Merged
Conversation
On Brave and Whale the frame view's layout left the browser view as it was when the appbar showed again, so the page stayed under the appbar and the top bar with it until the next input. Rivet's relayout now also lays the browser view's page area out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #189, release bar-folded passes on Chrome, Edge and Samsung but still fails on Brave and Whale (.scratch\bar-rows-after2). The capture after showing the appbar again shows the page still full width under the appbar, with the top bar over it. The trace has no "address bar: layout page" after "appbar: hidden false" on Brave. On folding, the browser view laid out only after the next click.
frame::relayoutran the frame view's LayoutImmediately. The frame view lays its client view out only when its bounds change, and the appbar's width does not change them.relayoutnow also callshooks::page_area::relayout, the browser view's LayoutImmediately that the split relayout message already uses. That reaches toggling, width drags and attach retries alike. The bar-folded row is the test.🤖 Generated with Claude Code