Skip to content

Codex Flight Suite: Consolidated Agent Flight and Metric Models - #4437

Closed
dieterolson wants to merge 2 commits into
mainfrom
consolidated/codex-flight-suite
Closed

Codex Flight Suite: Consolidated Agent Flight and Metric Models#4437
dieterolson wants to merge 2 commits into
mainfrom
consolidated/codex-flight-suite

Conversation

@dieterolson

Copy link
Copy Markdown
Collaborator

Consolidates agent work (2 PRs) authored by @d-sorgcodexagent[bot]:

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91ea71b931

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +85 to +89
src/chat
src/contracts.py
src/python/src/utils
src/shared
src/sidekick

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the sparse-scope contract with the workflow

When the repository's full pytest suite runs, tests/ops/test_cross_repo_python_integration.py::test_each_downstream_declares_its_required_sparse_scope fails because REQUIRED_SPARSE_PATHS still expects the former roots (chat, contracts.py, python/src/utils, shared, and sidekick), while this workflow now declares their src/-prefixed replacements. Update the contract expectations alongside these paths so the workflow change does not leave the suite permanently red.

Useful? React with 👍 / 👎.

@dieterolson
dieterolson enabled auto-merge (squash) August 13, 2026 19:46
@dieterolson

Copy link
Copy Markdown
Collaborator Author

Closing as an exact duplicate — this branch does not contain the work its title advertises

Verified with git on 2026-08-13 against origin/main @ 3e8959915:

1. #4437 and #4439 are the same snapshot.
consolidated/codex-flight-suite and consolidated/codex-rate-closure-suite resolve to the identical tree 7fc2ce41947d0b94ada71362b5c904d0459079c9. They are not merely similar; they are byte-for-byte the same content.

2. Neither branch contains any flight / metric-model work.
Both are exactly 2 commits ahead of main:

<lint>    fix(codex-*): update secrets baseline and resolve pre-commit lint issues
91ea71b93 🎨 Palette & Bolt Suite: Form Submission, Accessibility, SVG & CSV Optimizations (#4429)

That is #4429's palette/bolt suite squashed onto the branch, plus a lint commit. There is no flight-model or metric-model source change on this branch at all.

3. Everything here is already in #4438.
Normalising formatting on both sides (one ruff format pass with skip-magic-trailing-comma, identical settings, over all 93 differing .py files) leaves exactly two files different between this tree and consolidated/codex-variation-suite (#4438): src/movement_optimizer/gui/motion_tabs.py and src/movement_optimizer/gui/motion_view.py — both of which #4438 adds. This branch is a strict subset of #4438.

The palette/bolt content lands in #4438. Queued workflow runs on this branch are being cancelled to free the runner fleet (584 queued runs vs 1 executing at the time of this triage).

⚠️ The agent PRs listed in the description above were never merged into this branch

#4425 and #4307 are not on this branch and are not carried by #4438. They remain open and still require consolidation (CONS-B3 / CONS-B5 in the consolidation plan). Closing this PR does not close them and does not land their work.

auto-merge was automatically disabled August 14, 2026 02:48

Pull request was closed

This was referenced Aug 14, 2026
dieterolson added a commit that referenced this pull request Aug 14, 2026
…tion (#4438)

Consolidates the Palette & Bolt suite that originated in #4429 (squash 91ea71b,
itself covering merges of #4313, #4314, #4419, #4420) plus a movement-optimizer
motion-view extraction, with Python formatting corrected to the CI-pinned
ruff==0.14.10 and a Python 3.10 regression reverted.

Substance:
- Palette: form semantics, useId() label binding and role="alert" in
  RotationConverter.tsx and ODESolverCalculator.tsx.
- Bolt: single-pass CSV string building in chartSnapshot.ts, Array.from removal
  in explorer/csv.ts, fewer intermediate allocations for SVG paths in
  LinePlot/ScatterPlot/SpectrumPlot.tsx.
- refactor(movement-optimizer): extract MotionViewMixin into
  src/movement_optimizer/gui/motion_view.py.
- fix(ci): correct sparse-checkout paths in cross-repo-python-integration.yml.
- fix(tests): restore timezone.utc in test_action_audit.py; a pre-commit ruff
  pass had moved a noqa off its line, letting UP017 rewrite the import to
  datetime.UTC, which does not exist on Python 3.10.

Supersedes, all closed as containing nothing this branch lacks:
- #4429 — the original palette/bolt branch; quality-gate red at Format Check
  because its own pre-commit commits re-wrapped 86 files with a ruff that
  disagrees with the pin. Proven a strict semantic subset of this tree by
  normalising both sides with one ruff format pass.
- #4437 and #4439 — byte-identical trees to each other (7fc2ce4), each only
  the #4429 squash plus a lint commit, despite advertising flight and
  rate-of-closure work.

Palette/Bolt work items carried: #4310, #4311, #4313, #4314, #4418, #4419,
#4420, #4421.

None of the 59 still-open agent PRs named in the three closed PRs' descriptions
are in this diff; they remain open and unconsolidated.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant