🎨 Palette: Rotation Converter Forms - #4314
Conversation
Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5701cfcb4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div className="grid grid-cols-1 lg:grid-cols-2 gap-6 p-4"> | ||
| {/* Input Panel */} | ||
| <div className="bg-slate-800 rounded-lg p-6 space-y-4 text-white"> | ||
| <form onSubmit={handleCalculate} className="bg-slate-800 rounded-lg p-6 space-y-4 text-white"> |
There was a problem hiding this comment.
This changes submission from a button click to native form submission and adds generated label associations, but the reviewed tree contains no RotationConverter test covering Enter-key submission, request dispatch, or label/input linkage. Add regression coverage for these behaviors before landing the production change, as this repository explicitly requires a failing test before new functionality.
AGENTS.md reference: AGENTS.md:L68-L73
Useful? React with 👍 / 👎.
Performance Benchmark ResultsNo benchmark results available. |
|
Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
Consolidated into comprehensive PR #4429. |
Pull request was closed
Consolidation audit 2026-08-13 — this work is carried by #4438, not #4429#4429 ( A squash of #4429 — So #4438 was retitled CONS-B1 and landed; #4429, #4437 and #4439 were closed as superseded (#4437 and #4439 had byte-identical trees to each other). This PR's content is carried by #4438. |
…tion (#4438) Consolidates the Palette & Bolt suite that originated in #4429 (squash 91ea71b, itself covering merges of #4313, #4314, #4419, #4420) plus a movement-optimizer motion-view extraction, with Python formatting corrected to the CI-pinned ruff==0.14.10 and a Python 3.10 regression reverted. Substance: - Palette: form semantics, useId() label binding and role="alert" in RotationConverter.tsx and ODESolverCalculator.tsx. - Bolt: single-pass CSV string building in chartSnapshot.ts, Array.from removal in explorer/csv.ts, fewer intermediate allocations for SVG paths in LinePlot/ScatterPlot/SpectrumPlot.tsx. - refactor(movement-optimizer): extract MotionViewMixin into src/movement_optimizer/gui/motion_view.py. - fix(ci): correct sparse-checkout paths in cross-repo-python-integration.yml. - fix(tests): restore timezone.utc in test_action_audit.py; a pre-commit ruff pass had moved a noqa off its line, letting UP017 rewrite the import to datetime.UTC, which does not exist on Python 3.10. Supersedes, all closed as containing nothing this branch lacks: - #4429 — the original palette/bolt branch; quality-gate red at Format Check because its own pre-commit commits re-wrapped 86 files with a ruff that disagrees with the pin. Proven a strict semantic subset of this tree by normalising both sides with one ruff format pass. - #4437 and #4439 — byte-identical trees to each other (7fc2ce4), each only the #4429 squash plus a lint commit, despite advertising flight and rate-of-closure work. Palette/Bolt work items carried: #4310, #4311, #4313, #4314, #4418, #4419, #4420, #4421. None of the 59 still-open agent PRs named in the three closed PRs' descriptions are in this diff; they remain open and unconsolidated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
💡 What: Wrapped inputs in
<form>and dynamically mapped ID to<label htmlFor>. Addedrole="alert"for the error messages.🎯 Why: This enables screen readers to map input sections for improved visibility, and native
Entersubmission.📸 Before/After: Before this the app was a series of
<div>withonClickinputs, and inputs and error messages didn't have ID mappings. Now the UI fields have<label>attributes and errors haverole="alert".♿ Accessibility: Added missing input labeling using
htmlForvia ReactuseId(), implemented native "Enter" key submission using semantic<form>structure, and improved error message announcements withrole="alert".PR created automatically by Jules for task 12035677392027795396 started by @dieterolson