⚡ Bolt: Avoid intermediate array allocations for SVG paths in plots - #4419
⚡ Bolt: Avoid intermediate array allocations for SVG paths in plots#4419dieterolson wants to merge 1 commit into
Conversation
Replaced `segments.push(...); return segments.join(" ")` with a single-pass `for` loop and string concatenation (`d += ...`) in `LinePlot`, `ScatterPlot`, and `SpectrumPlot`'s `buildPath` functions to reduce intermediate array allocation and V8 garbage collection pressure during high-frequency UI renders.
Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Consolidated into comprehensive PR #4429. |
Consolidation audit 2026-08-13 — this work is carried by #4438, not #4429#4429 ( A squash of #4429 — So #4438 was retitled CONS-B1 and landed; #4429, #4437 and #4439 were closed as superseded (#4437 and #4439 had byte-identical trees to each other). This PR's content is carried by #4438. |
…tion (#4438) Consolidates the Palette & Bolt suite that originated in #4429 (squash 91ea71b, itself covering merges of #4313, #4314, #4419, #4420) plus a movement-optimizer motion-view extraction, with Python formatting corrected to the CI-pinned ruff==0.14.10 and a Python 3.10 regression reverted. Substance: - Palette: form semantics, useId() label binding and role="alert" in RotationConverter.tsx and ODESolverCalculator.tsx. - Bolt: single-pass CSV string building in chartSnapshot.ts, Array.from removal in explorer/csv.ts, fewer intermediate allocations for SVG paths in LinePlot/ScatterPlot/SpectrumPlot.tsx. - refactor(movement-optimizer): extract MotionViewMixin into src/movement_optimizer/gui/motion_view.py. - fix(ci): correct sparse-checkout paths in cross-repo-python-integration.yml. - fix(tests): restore timezone.utc in test_action_audit.py; a pre-commit ruff pass had moved a noqa off its line, letting UP017 rewrite the import to datetime.UTC, which does not exist on Python 3.10. Supersedes, all closed as containing nothing this branch lacks: - #4429 — the original palette/bolt branch; quality-gate red at Format Check because its own pre-commit commits re-wrapped 86 files with a ruff that disagrees with the pin. Proven a strict semantic subset of this tree by normalising both sides with one ruff format pass. - #4437 and #4439 — byte-identical trees to each other (7fc2ce4), each only the #4429 squash plus a lint commit, despite advertising flight and rate-of-closure work. Palette/Bolt work items carried: #4310, #4311, #4313, #4314, #4418, #4419, #4420, #4421. None of the 59 still-open agent PRs named in the three closed PRs' descriptions are in this diff; they remain open and unconsolidated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
💡 What: Replaced intermediate array allocations (
segments.push(...)followed by.join(" ")) with a single-passforloop and direct string concatenation (d += ...) when building SVG path strings.🎯 Why: During high-frequency re-renders (like updating real-time data plots), repeatedly allocating arrays and invoking closures creates unnecessary memory overhead and forces the V8 engine into frequent garbage collection pauses, which degrades UI responsiveness.
📊 Impact: Reduces intermediate array allocations during path building for the
LinePlot,ScatterPlot, andSpectrumPlotdata visualizations from O(N) objects to zero, directly reducing main thread stalls caused by garbage collection.🔬 Measurement: Verify by rendering large streams of time-series data or scatter point data using the respective components and observing memory snapshots in the Chrome DevTools Memory tab; the amount of memory allocated for
(string)arrays during redraws will be noticeably reduced.PR created automatically by Jules for task 15859349586633057274 started by @dieterolson