fix(admission): preserve uv global artifact operand evidence - #427
Merged
seonghobae merged 5 commits intoSep 14, 2026
Merged
seonghobae merged 5 commits into
seonghobae merged 5 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #426. Serialized child of exact
#129@24747e2724e3c21b9bdf78a3a9d51aac2b6694b9.Fresh review found that
policy::validate_artifact_operandsstill recognized uv install grammar only whenpip installwas at fixed argv positions. Parser-valid uv global options could therefore erase causalArtifactNotApprovedevidence for an undeclared package even though the deliberately narrow supported-command grammar still blocked the request.Hostile semantic RED
Test-only exact head
d0a0e38f7cea8b38cb195a5f9148e39fd36e20bdexercised:uv --color never pip install cwl-example==1.2.3 undeclared-example==9.9.9 --require-hashes --no-deps --no-python-downloadsRequired behavior is fail-closed with both generic
ForbiddenCommandand causalArtifactNotApproved, whilecommand_sha256remains bound to the exact submitted argv. A consumed--target /tmp/...value must not be fabricated as an artifact operand, non-install uv grammar must not inherit install-operand semantics, and the ordinary supported install remains an Allow control.CI
34795158441reached RustTestafter formatting passed and failed on the intended semantic contract; Fuzz34795158448completed SUCCESS. Because production source atd0a0e38...was byte-identical to the exact parent and only the hostile contract differed, this is the semantic RED. The older2bd7486df27bf66c5916974aa1e077b5cfd62a9fformatting failure is explicitly non-semantic.Minimum causal production repair
Exact
fd19ac126a0e90a60164f8f9a24a47ea29490336makesvalidate_artifact_operandsandis_install_root_selector_valuereuseuv_active_command_index, so operand evidence begins only at the activepip installslice after parser-valid uv global options.supported_install_commandremains deliberately narrow; no parser is duplicated, no package manager is executed, and no quarantine/EgressWeave/contextual-orchestrator/AppGuardrail logic is copied.Fuzz
34804779748completed SUCCESS onfd19...; CI34804779640failed onlycargo fmt --check. Exact630cc7fc59b7ca7ea5ebe2b1503e9e499da2fdbathen applied exactly the emitted rustfmt diff with no semantic production change. On630cc7fc..., Fuzz34817855887completed SUCCESS and CI34817855860reached workspace tests.Causal test-contract repair
The
630cc7fc...CI failure exposed a fixture/oracle defect rather than a production regression. The non-install negative control changed argv touv --color never pip sync undeclared-example==9.9.9 ...whileInstallIntent.artifactsstill declared approvedcwl-example==1.2.3. Wardnet's independent immutable artifact/argv binding correctly emittedArtifactNotApprovedbecause the declared artifact argument was absent; that reason did not come frompip installoperand parsing.Current exact head
27e450bcfc8280376619f0331766eb2ed0efc796changes only that negative-control fixture: it retains declaredcwl-example==1.2.3and also carriesundeclared-example==9.9.9underuv ... pip sync. This preserves the general artifact-binding invariant while isolating the intended assertion that non-install uv grammar must not inheritpip installoperand semantics. Production code is byte-identical to630cc7fc....Exact-current CI
34847171263and Fuzz34847171299are QUEUED at the latest fresh read. CodeRabbit and Devin Review commit statuses are success; there are currently no submitted PR reviews or inline review threads. Central hosted-runner admission evidence for this exact head is handed to.github#712; no Wardnet workflow/runner selector change or no-op redispatch is justified.Keep Draft until both exact-current repository workflows are terminal GREEN. Then re-read exact #129, reviews/threads/checks and candidate-base compatibility and integrate only by ordinary expected-head/non-force merge if still valid. No force push, destructive rebase, self/model approval, gate weakening, synthetic status, source churn merely to redispatch, or routine bypass.