test(admission): expose uv global indirect source evidence gap - #429
Merged
seonghobae merged 3 commits intoSep 15, 2026
Merged
seonghobae merged 3 commits into
seonghobae merged 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 14, 2026
seonghobae
marked this pull request as ready for review
September 15, 2026 17:01
seonghobae
merged commit Sep 15, 2026
951b3cb
into
feat/agent-artifact-admission
4 of 5 checks passed
seonghobae
deleted the
fix/uv-global-indirect-artifact-source-evidence
branch
September 15, 2026 17:01
seonghobae
added a commit
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #428. Serialized child of exact
#129@625879592f0a4d7b06374df2a827cf08f304feb3after ordinary integration of #427.Hostile RED
The test-only lineage added a realistic parser-valid uv global-option contract around:
uv --color never pip install -r cwl-example==1.2.3 --require-hashes --no-deps --no-python-downloadsHere
cwl-example==1.2.3is the requirements-file operand consumed by-r, not a reviewed direct package operand. Global-option uv grammar intentionally remains outsidesupported_install_command, so the request must keepForbiddenCommandwhile also preserving causalArtifactNotApprovedevidence for the unapproved indirect source.Controls cover attached
--color=never, non-installuv ... pip sync, the ordinary reviewed direct install, exact submitted-argv hashing, and the previously repaired rule that a consumed install-root value cannot masquerade as the approved artifact token.Exact test-only
6619db4fb82203af6cc6ac55c788fa679af9c33aestablished the intended hosted semantic RED. Fuzz34911607856completed SUCCESS. CI34911607878, rust job104200113638, acquired hostedubuntu-24.04, passed checkout, Rust toolchain andcargo fmt --check, then failedcargo test --locked --workspaceat exactly the two new hostile assertions:uv_global_requirement_source_preserves_indirect_artifact_evidenceandattached_uv_global_option_preserves_indirect_artifact_evidence. Both observed only[ForbiddenCommand], proving that parser-valid uv global options erased the requiredArtifactNotApprovedcausal evidence. The other three controls passed. This is semantic RED, not runner/bootstrap/format noise.Minimum causal repair
Current exact repair head is
0f206d6cb23ca88abfd6f0c0a84e1dcba6e35969. The production delta is limited topolicy.rs::requests_indirect_artifact_source(): it reuses existinguv_active_command_index(), requires exact activepipfollowed by exactinstall, and scans onlyarguments[pip_index + 2..]for the already-reviewed indirect-source selectors.supported_install_commandis unchanged, no second uv parser was introduced, and no package-manager/runtime execution or foreign-owner logic was copied.Exact-head GREEN — refreshed 2026-09-16 KST
On unchanged exact repair head
0f206d6cb23ca88abfd6f0c0a84e1dcba6e35969:34927770706/ rust job104249367485is terminal SUCCESS.34927770671same-head retry has now materialized on hosted compute and is terminal SUCCESS; fuzz job104374556379completed successfully without any source/head movement.#129@625879592f0a4d7b06374df2a827cf08f304feb3.The earlier pre-materialization Fuzz failure/queue specimen remains valid central runner evidence already handed to
.github#712, but it is superseded as child readiness evidence by the successful unchanged-head retry. No no-op source churn, runner-selector change, predecessor-result transfer, synthetic status, self/model approval, gate weakening, or bypass was used.This child is therefore ready for ordinary expected-head integration into #129. After integration, every #129 exact-head gate must be reacquired because the root head will move; issue #428 remains open until the effective repair reaches protected
mainor a verified complete successor.