feat(scanner): reject malformed UTF-8 plugin manifests - #1154
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 16:14 UTC records Draft #1154 `ee43e7d` stacked on #1153. - Invalid UTF-8 plugin/MCP JSON fails closed with label-only snippets. - Valid CJK, bidi concealment, and Infinity stay their own classes. Rationale: - #999 is the single writer of the product-technical gap baseline. - #1099 remaining surfaces stay on stacked successors, not Close. Tests: - documentation-only; detector evidence lives on #1154 (1614/1614)
This was referenced Sep 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current repair boundary — 2026-09-12
feat/claude-plugin-nonstandard-json-1099@b02bfdecec575edf593a72388df2cd749afdf204fd8673ea21543eb40f05ec0017d20447432d866e3b000417cf1883e8930b723194ff0cc83f343568ee43e7d…and current feat(scanner): reject non-standard plugin JSON constants #1153 headb02bfde…; no force updatePYTHONPATH=. python -m pytest -q tests/test_claude_plugin*.py→ 182 passed;py_compileandgit diff --checkpassedSuccessor of #1153 / issue #1099. Does not Close those. Bidi/control stays the concealment class. Duplicate members stay #1129. Nonstandard JSON constants stay #1153.
Unique delta
Fail closed when marketplace/plugin/MCP JSON bytes are not valid UTF-8 (
claude-plugin-malformed-utf8):claude-plugin-concealed-identityInfinitystaysclaude-plugin-nonstandard-json-constantTest plan
tests/test_claude_plugin_malformed_utf8.py)Relates to #1099. Relates to #1153.