Skip to content

feat(scanner): reject malformed UTF-8 plugin manifests - #1154

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-nonstandard-json-1099from
feat/claude-plugin-malformed-utf8-1099
Draft

seonghobae wants to merge 3 commits into
feat/claude-plugin-nonstandard-json-1099from
feat/claude-plugin-malformed-utf8-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1153 / issue #1099. Does not Close those. Bidi/control stays the concealment class. Duplicate members stay #1129. Nonstandard JSON constants stay #1153.

Unique delta

Fail closed when marketplace/plugin/MCP JSON bytes are not valid UTF-8 (claude-plugin-malformed-utf8):

  • truncated multibyte sequence in plugin.json fails admission
  • invalid continuation and lone-surrogate UTF-8 fail admission
  • valid Korean/Japanese description is not this finding
  • bidi concealment stays claude-plugin-concealed-identity
  • feat(scanner): reject non-standard plugin JSON constants #1153 Infinity stays claude-plugin-nonstandard-json-constant
  • invalid JSON that is valid UTF-8 stays the JSON-decode class
  • snippets are short labels and omit secrets and raw invalid bytes

Test plan

  • RED then GREEN (tests/test_claude_plugin_malformed_utf8.py)
  • Detector statement coverage 1614/1614 with plugin suites on Python 3.13
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1153.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 16:14 UTC records Draft #1154 `ee43e7d` stacked on #1153.
- Invalid UTF-8 plugin/MCP JSON fails closed with label-only snippets.
- Valid CJK, bidi concealment, and Infinity stay their own classes.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; detector evidence lives on #1154 (1614/1614)
seonghobae added a commit that referenced this pull request Sep 7, 2026
Refresh the single-writer gap baseline from live exact-head evidence:
Draft #1155 on #1154, and G-06 #1152 hosted coverage SUCCESS.
Relates to #1099.
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant