Skip to content

feat(scanner): reject non-NFC plugin identity names - #1155

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-malformed-utf8-1099from
feat/claude-plugin-normalized-name-1099
Draft

seonghobae wants to merge 3 commits into
feat/claude-plugin-malformed-utf8-1099from
feat/claude-plugin-normalized-name-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1154 / issue #1099. Does not Close those. Does not steal G-06 #1152, #1154 malformed UTF-8, #1153 nonstandard JSON, or concealment unique delta.

Unique delta

Fail closed when a plugin or marketplace identity name is not Unicode NFC (claude-plugin-inconsistent-normalized-name):

  • combining-mark NFD cafe\u0301 fails admission
  • precomposed NFC caf\u00e9 is not this finding
  • Hangul syllables stay admitted
  • ASCII names stay admitted
  • marketplace plugins[].name uses the same contract
  • README text is not a manifest identity
  • bidi stays claude-plugin-concealed-identity
  • Infinity stays claude-plugin-nonstandard-json-constant
  • snippets are the label name and omit secrets, bidi, and raw combining marks

#1154 remains owner of malformed UTF-8 JSON bytes.

Test plan

  • RED then GREEN (tests/test_claude_plugin_normalized_name.py)
  • Detector statement coverage 1633/1633 with plugin suites on Python 3.13
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1154.

RED contract for combining-mark plugin and marketplace names.
NFC Hangul and ASCII stay admitted. Relates to #1099.
Fail closed when a plugin or marketplace name is not Unicode NFC.
Hangul and precomposed Latin stay admitted. Relates to #1099.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Refresh the single-writer gap baseline from live exact-head evidence:
Draft #1155 on #1154, and G-06 #1152 hosted coverage SUCCESS.
Relates to #1099.

Copy link
Copy Markdown
Contributor Author

Stacked successor Draft #1156 (feat/claude-plugin-vendored-scope-1099 @ a6f6a742701c263efcd83402da1815e065d69706) adds claude-plugin-vendored-scope-undeclared for undeclared vendor/, node_modules/, dist/, and *.min.js copies.

NFC / Hangul identity remains this PR. #1156 does not Close #1155 or #1099. Inventory stays evidence, not permission.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 17:18 UTC records Draft #1156 `a6f6a74` stacked on #1155.
- Undeclared vendor/node_modules/dist copies fail as one scope finding.
- Hook walks skip those trees so admission is not a per-file flood.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; detector evidence lives on #1156 (1709/1709)
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant