feat(scanner): reject non-NFC plugin identity names - #1155
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
Contributor
Author
|
Stacked successor Draft #1156 ( NFC / Hangul identity remains this PR. #1156 does not Close #1155 or #1099. Inventory stays evidence, not permission. |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 17:18 UTC records Draft #1156 `a6f6a74` stacked on #1155. - Undeclared vendor/node_modules/dist copies fail as one scope finding. - Hook walks skip those trees so admission is not a per-file flood. Rationale: - #999 is the single writer of the product-technical gap baseline. - #1099 remaining surfaces stay on stacked successors, not Close. Tests: - documentation-only; detector evidence lives on #1156 (1709/1709)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current repair boundary — 2026-09-12
feat/claude-plugin-malformed-utf8-1099@fd8673ea21543eb40f05ec0017d20447432d866ec40e616fa5e4a8268152132e777cbfd8e3da1d1437a6a896b9db048de415ffcee23ea52f35ffe189b85b936…and current feat(scanner): reject malformed UTF-8 plugin manifests #1154 headfd8673e…; no force updatePYTHONPATH=. python -m pytest -q tests/test_claude_plugin*.py→ 192 passed;py_compileandgit diff --checkpassedSuccessor of #1154 / issue #1099. Does not Close those. Does not steal G-06 #1152, #1154 malformed UTF-8, #1153 nonstandard JSON, or concealment unique delta.
Unique delta
Fail closed when a plugin or marketplace identity name is not Unicode NFC (
claude-plugin-inconsistent-normalized-name):cafe\u0301fails admissioncaf\u00e9is not this findingplugins[].nameuses the same contractclaude-plugin-concealed-identityInfinitystaysclaude-plugin-nonstandard-json-constantnameand omit secrets, bidi, and raw combining marks#1154 remains owner of malformed UTF-8 JSON bytes.
Test plan
tests/test_claude_plugin_normalized_name.py)Relates to #1099. Relates to #1154.