Skip to content

feat(scanner): reject non-standard plugin JSON constants - #1153

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-deceptive-description-1099from
feat/claude-plugin-nonstandard-json-1099
Draft

seonghobae wants to merge 3 commits into
feat/claude-plugin-deceptive-description-1099from
feat/claude-plugin-nonstandard-json-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1151 / issue #1099. Does not Close those. Does not steal G-06 #1152, #1151 deceptive-description, or #1150 browser-profile unique delta. Duplicate JSON members stay claude-plugin-duplicate-json-member.

Unique delta

Fail closed on non-standard JSON constants (claude-plugin-nonstandard-json-constant):

  • plugin.json timeout: NaN fails admission
  • Infinity and -Infinity fail admission
  • a finite JSON number is not this finding
  • duplicate object members stay claude-plugin-duplicate-json-member
  • README text is not a manifest
  • truncated JSON is a parse failure, not this class
  • feat(scanner): reject deceptive plugin capability descriptions #1151 deceptive descriptions stay that class
  • snippets are the constant token and omit secrets and raw bidi

#1151 remains owner of deceptive plugin/skill/command descriptions.

Test plan

  • RED then GREEN (tests/test_claude_plugin_nonstandard_json.py)
  • Detector statement coverage 1576/1576 with plugin suites on Python 3.13
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1151.

RED contract for NaN, Infinity, and -Infinity in plugin manifests.
Duplicate members stay their own class. Relates to #1099.
Fail closed on NaN, Infinity, and -Infinity in plugin manifests.
Duplicate members stay their own class. Relates to #1099.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Refresh the single-writer gap baseline from live exact-head evidence:
Draft #1153 on #1151. Relates to #1099.

Copy link
Copy Markdown
Contributor Author

Stacked successor: #1154 (feat/claude-plugin-malformed-utf8-1099 @ ee43e7d).

It owns the remaining issue #1099 TDD item 4 malformed UTF-8/Unicode slice (claude-plugin-malformed-utf8). It does not Close #1099 or this PR. Bidi/control stays claude-plugin-concealed-identity. Duplicate members stay #1129. Non-standard JSON constants stay this PR.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 16:14 UTC records Draft #1154 `ee43e7d` stacked on #1153.
- Invalid UTF-8 plugin/MCP JSON fails closed with label-only snippets.
- Valid CJK, bidi concealment, and Infinity stay their own classes.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; detector evidence lives on #1154 (1614/1614)
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant