feat: add evidence-centered HR workspace slice - #53
Conversation
📝 WalkthroughWalkthroughHR 워크스페이스 UI와 보호된 People·Job Analysis 조회를 추가했습니다. Storybook과 Playwright 검증을 구성하고, CI·저장소 계약·문서·매니페스트를 ChangesHR 워크스페이스 통합
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to The HR workspace can continue showing previously approved People fields after access is denied and may display an older response after a newer request, creating a bounded privacy and correctness risk; inconsistent service dependency versions may also break reproducible installation or integration. These issues should be fixed or explicitly accepted before merge. Sequence Diagram(s)sequenceDiagram
participant Browser
participant HRWorkspaceApp
participant PeopleAPI
participant JobAnalysisAPI
Browser->>HRWorkspaceApp: 조회 폼 제출
HRWorkspaceApp->>PeopleAPI: 목적 코드와 인증 헤더로 People 조회
PeopleAPI-->>HRWorkspaceApp: fields 응답 또는 401/403 오류
HRWorkspaceApp->>JobAnalysisAPI: 목적 코드와 인증 헤더로 snapshot 조회
JobAnalysisAPI-->>HRWorkspaceApp: snapshot 응답 또는 오류
HRWorkspaceApp-->>Browser: 결과 또는 오류 상태 렌더링
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 15.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 9 files. (23 skipped: 23 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scope
Adds the dependency-free HR Home / Employee Profile fixture, shared design-token consumption, local Storybook, purpose-bound evidence review interactions, bitemporal presentation, high-impact confirmation, accessibility assertions, and English/Korean labels. This remains fixture/component-state evidence only: it does not claim deployed customer UI, People API write integration, production psychometric compute, or ownership of a dedicated-writer dependency.
This branch also owns the page-level keyboard bypass interaction for the existing HR Workspace UI. The Figma baseline was re-read without mutating the design file: nodes
1:10(HR Home) and1:28(Employee Profile) remain the visual geometry baseline. The bypass control is intentionally focus-only until keyboard focus, so its visible state is captured in Storybook and Chromium rather than by creating a conflicting Figma geometry change.Current branch truth — 2026-09-01
Fresh base at the latest read:
develop@9e3e4847510e1e612b48474ba42b177b8ed824dfExact head:
016f27e13f7a47cb78a1c936aa533cc8daa2c66cGitHub reports open · Draft · mechanically mergeable. Re-fetch all three values before acting.
The Draft flag is authoritative: event history shows repeated Ready/Draft lifecycle mutations under a separate same-repository writer, so this lane does not race that lifecycle owner. Older evidence at predecessor heads is stale and is not reused.
Latest owner-side RED → root-cause repair
A separate writer advanced the canonical branch to predecessor
d955faf5d1e7e10ea3dda3b9deaa74db940bf634to reseal the new HR Workspaceindex.htmlprovenance. The new index evidence itself was correct, but that commit also changed the unrelateddatabase/migrations/0005_outbox_delivery_finalization.sqlmanifest digest to a value that did not match the file on disk.Foundation run
33042232951, job98418198435, proved exact checkout ofd955faf...and failed atValidate foundation packwith a deterministic provenance mismatch for migration 0005. The same job's--print-manifestrepair output proved the authoritative artifact evidence remained SHA-256b7e8790595b288f752d6ef5cc6cbfe4e1b6712248f5b7a3a25fa60016b6a4961, 6,125 bytes, 170 lines. All PostgreSQL integrity matrix jobs in that run were already GREEN, so changing migration source or weakening the validator would have been the wrong remedy.Root repair
016f27e13f7a47cb78a1c936aa533cc8daa2c66crestores only that unrelated migration digest while preserving the valid new HR Workspace index provenance. No product behavior, database migration, validation rule, security gate, or dependency contract was weakened.The earlier keyboard-bypass repair remains intact: the locale E2E binds to the stable skip-link DOM identity and verifies the active English/Korean accessible name instead of re-resolving a stale English role locator after the locale switch.
Latest thread inspection found all inline review threads resolved; submitted reviews were COMMENTED only. Re-fetch after any push.
Exact-current-head evidence and superseded security result
The Orgmetra-hosted product/repository workflows recorded on exact head
016f27e...were terminal-success on 2026-08-27, including Foundation, Recovery, HR Workspace Browser E2E, People/Job-Analysis APIs, migration, candidate/requisition/offer/selection quality, SAST and the then-current central Security Scan.However, the 2026-08-27 Security Scan is not valid evidence for the current Dependency Review contract. Its
dependency-reviewjob queried the exactdevelop@9e3e484...→016f27e...dependency comparison, received HTTP403, emittedsupported=false, skipped the pinnedactions/dependency-review-actionstep, and still returned SUCCESS. That was the predecessor fail-open behavior subsequently repaired centrally by.github#810/#897.The current central Security Scan correctly fails closed on any non-200/malformed/transport-failed exact dependency comparison. Public Orgmetra canaries continue to expose the upstream availability/configuration incident as HTTP 403, so this PR must not reuse its old Security GREEN or claim current required-workflow completeness. No OSV/Trivy/Scorecard/SAST result substitutes for authoritative Dependency Review.
Do not make a no-op product commit merely to manufacture a newer check. Once
.github#810restores authoritative dependency comparison availability, run/retrigger the then-current central required workflow on this unchanged or meaningfully advanced exact head and require the pinned Dependency Review action itself to execute to a terminal result.Current merge governance
.github#772supersedes the former2 independent approvals + last-push approvaltarget. The ContextualWisdomLab fleet currently has one human maintainer and no genuinely independent human reviewer capacity; a positive generic human approval count is therefore structurally unsatisfiable.The compliant target is:
required_approving_review_count = 0while independent human capacity does not exist;require_last_push_approval = false;OrganizationAdmin/alwaysbypass. Emergency repair belongs to a separately governed, time-bounded, auditable break-glass path.Live inherited organization ruleset
18156473still drifts from that target by requiring one generic approving review and retaining routine OrganizationAdmin bypass.Orgmetra#89mirrors the consumer impact;.github#772/#1351/#1340/#1200own the policy/control-plane repair and.githubPR #1176 is the canonical audit writer.Stack / readiness
This PR remains the dependency root for the current job-analysis/Job Architecture stack, including #130 and #147. Do not advance descendants as if this root were merge-authorized. Before changing Draft state or merging, freshly resolve:
There is currently no qualifying independent
APPROVEDreview, but under the current solo-maintainer decision that fact must not be converted into a fabricated approval requirement. Exact-head technical evidence is still required and does not transfer across pushes.Do not self-approve, use routine administrator bypass, weaken or substitute a gate, race the lifecycle writer, or transfer predecessor/foreign evidence.