feat(ui): add governed Job Architecture workspace states - #147
Draft
seonghobae wants to merge 10 commits into
Draft
feat(ui): add governed Job Architecture workspace states#147seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible gap
Protected PRD and Figma
Orgmetra Baselinenode1:16require a Job Architecture workspace that presents versioned Job evidence, Task → FJA → KSAO lineage, an evidence drawer, and publish-only-after-SME-review behavior. #101/#109 own Job-grade review/persistence and #117 owns model-assisted Job Analysis drafting, while #25/#38 own governed Job Analysis evidence/snapshot boundaries. This child remains presentation/interaction-only and does not create a shadow domain authority.The branch is stacked on #130 and does not create or mutate Job Analysis truth, Job-grade truth, Position, Assignment, compensation, candidate status, or an employment decision.
Contract-first RED → root repair
Contract head
15c6328d2491009ffca40faaa28d38bb01ca0238contained the exact-coverage workflow and focused interaction/privacy/fail-closed regressions before the production state module existed. Hosted run33169736884, job98843660150, checked out that exact SHA and failed withERR_MODULE_NOT_FOUNDfor intentionally absentapps/hr-workspace/job-architecture-state.js: genuine RED evidence.Root implementation commit
d24e1069c549f9be33b164d0ab0237b4b080b513adds the smallest presentation-state boundary. It uses exact built-in strings plus own-key state membership, rejects prototype-inheritedconstructor/toString/__proto__, and exposes boundedidle / loading / draft / review / publishing / published / denied / stale / evidenceBlocked / errorstates.draftis read-only Task → FJA → KSAO/source-provenance evidence and explicitly not published Job truth; model-assisted output remains untrusted draft evidence.reviewrequires accountable SME confirmation of Job scope, evidence/provenance, limitations, actor, purpose, reason, and evidence version, without candidate, compensation, or employment-decision authority.publishingdisables duplicate action and does not claim success.publishedis asserted only after authoritative Job Analysis publication plus immutable audit evidence and remains read-only; it does not itself mutate Position, Assignment, compensation, or candidate status.Figma / Storybook / accessibility evidence
Figma
Orgmetra Baselinenode1:16defines Task → FJA → KSAO, evidence drawer and SME-gated publish behavior; Storybook Inventory node1:64defines governed interaction states. The branch adds tokenized CSS and Storybook states using existing Orgmetra interaction/focus tokens, a 44px minimum action target,aria-busy, read-only/high-risk-confirmation/permission-denied/validation-error semantics, and APA 7 doctoring for WCAG 2.2, WAI-ARIA 1.2 and O*NET occupational-information context.Parent synchronization — 2026-09-01
The previous child exact head
26e81931ec031bd9ac72f0053839cae58c21f6bbwas based on parent #130 predecessor68896baa692ecf6fec8f21cfe5d981440be6071c, while #130 had advanced toc92749cf5889a39de1ba8036742f96fd3451f459with a bounded Storybook compatibility fix inapps/hr-workspace/protected-read-state.stories.js.Fresh ancestry comparison proved the child was ahead 9 / behind 1 and the parent-only change did not overlap any of this PR's seven owned Job Architecture files. The existing child branch was therefore synchronized non-destructively with a two-parent merge commit rather than rebasing or force-pushing.
Current exact head:
283da6050d487d597351aafcd248c3a92387f970Current base/parent: #130
feat/hr-workspace-protected-read-state@c92749cf5889a39de1ba8036742f96fd3451f459Post-merge ancestry proof: parent merge-base is exactly
c92749cf…; child is ahead 10 / behind 0. GitHub reports open · Draft · mechanically mergeable. Re-fetch these values before acting.Exact-current-head evidence
The predecessor Job Architecture focused run on
26e81931…is historical only and does not transfer to283da605…. The parent sync creates a new exact head and therefore requires fresh focused tests, review threads and any applicable central/stacked required-workflow evidence.No claim of current-head GREEN or merge readiness is made until those fresh checks conclude. The parent #53 chain also remains blocked from release-readiness by the current central Dependency Review availability incident: its old Security GREEN was produced by predecessor fail-open logic after HTTP 403 and a skipped Dependency Review action.
Current governance and stack discipline
Keep Draft and process causal order #53 → #130 → #147.
.github#772supersedes the old impossible2 independent approvals + last-pushexpectation: the current one-human-maintainer fleet must not fabricate approvals. The target removes only the unsatisfiable generic human approval/named-reviewer/last-push dependency while preserving fail-closed review threads and deterministic OpenCode/Noema/Strix/Security/SAST/Dependency Review/coverage/provenance/product gates, deletion/non-fast-forward protection, and no routine administrator bypass.After #53 and #130 integrate, retarget/revalidate this child against fresh
develop, reconcile any intervening Figma/Storybook/domain changes, and rerun applicable browser/accessibility/Foundation/Recovery/SAST/Security and central required workflows on one exact head.Do not self-approve, manufacture reviewer identity, use routine administrator bypass, weaken/substitute a gate, create a Job Analysis/Job-grade shadow authority, race another lifecycle writer, or transfer predecessor evidence.