feat(ui): add governed validation dashboard states - #145
Draft
seonghobae wants to merge 9 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible validation gap
The protected product baseline still names the Validate surface while fresh Figma
Orgmetra BaselineStorybook Inventory node1:64publishes aValidationMetriccomponent and requires default / hover / focus / disabled / loading / validation-error / read-only / high-risk-confirmation behavior, with exact-value tables accompanying every chart. No existing open PR owned the Validation dashboard presentation shell when this dependency-first slice was created.This Orgmetra-only child is stacked on #130 and owns presentation/interaction only. It does not duplicate validity-study persistence, criterion/Job scope, selection monitoring, psychometric/statistical compute, candidate lifecycle, or employment-decision authority. Governed validation evidence remains read-only; visualizations require an exact-value table and do not establish causality or authorize ranking, rejection, progression, compensation, or an employment decision.
Contract-first RED → root repair
Contract-only head
2f6aec8940f557a3df93cb584648facfc068ab88produced genuine hosted RED inHR Workspace Validation Dashboard State Qualityrun33153931622, job98792136260: the runner checked out and proved that exact SHA, set up Node24.19.0, then the focused contract failed withERR_MODULE_NOT_FOUNDfor intentionally absent productionapps/hr-workspace/validation-dashboard-state.js.The smallest root repair adds that governed presentation state model with exact primitive/own-key fail-closed state acceptance, value-minimized evidence, causal/decision-authority disclaimers, exact-value-table requirement, accessible loading/error/read-only semantics, existing Orgmetra tokens, Storybook states, primary accessibility/validation references, and traceability. Prototype-inherited
constructor,toString, and__proto__are rejected.Exact-current-head evidence
Current exact head:
45accc8f2405013e4520e76fa70d01cbebf3c5cc.Fresh live base:
68896baa692ecf6fec8f21cfe5d981440be6071c.GitHub reports the PR open, draft, mergeable
MERGEABLE, merge stateCLEAN, review decisionNONE.The dedicated Validation dashboard state contract is terminal SUCCESS: run 33285376235, job 99187548564, on the exact current head.
Current exact-head review state: 0 unresolved thread(s); APPROVED review records: none.
This evidence section was synchronized on 2026-08-30. Any predecessor-head claims or prior run IDs elsewhere in this PR body are historical and do not transfer to the current head. Keep this PR governed by the current exact-head checks, review threads, effective protection, and independent approval requirements.
Ownership / dependency discipline
Recorded base/parent: #130
feat/hr-workspace-protected-read-state@68896baa692ecf6fec8f21cfe5d981440be6071c.Current #130 head is c92749c (PR #130 remains open and unmerged). Keep Draft and process #53 → #130 first. After #130 integrates, retarget/revalidate this child against fresh
develop, reconcile intervening Validate/Figma/Storybook changes, and rerun every applicable browser/accessibility/Foundation/Recovery/SAST/Security and central required workflow on one resulting exact head. Parent/predecessor checks and reviews never transfer.Do not self-approve, use routine administrator bypass, weaken a gate, create a statistical-kernel or selection-decision shadow owner, or mutate a dedicated-writer dependency.