feat(ui): add governed Job grade review states - #134
Draft
seonghobae wants to merge 11 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible interaction gap
Parent #130 provides the shared protected-read accessibility state contract, but Job grade design review still lacked workflow-specific UI evidence for loading authoritative Job/Job Analysis evidence, human-only review, immutable review recording, stale evidence, authorization denial, and failure recovery.
This dependency-first slice consumes #130's existing Figma/Storybook interaction semantics and mirrors the separate #101 Job Grade Design Review governance boundary without importing that unmerged package, creating compensation/employment-decision authority, or reading foreign application tables.
RED → governed implementation
Initial head
772a69fe6ce6e5e6b008c29828eb966c90326504intentionally contained only the regression and focused workflow; production Storybook/state owners were absent, so the gate was non-passing rather than silently absent.After implementing the bounded state model, Storybook, CSS, traceability and primary accessibility references, exact head
56b759720ba6a56ec831bb16da8f313033100f47produced a real hosted failure in run33091441945, job98585026421, at the exact-coverage interaction test. The first causal boundary was the regression itself: its whole-serialized-string privacy regex rejected required constant governance copy such as “does not authorize compensation,” even though no compensation value or field was present. Production semantics were not weakened. The regression was repaired to verify the exact allowed view-model key set plus explicit absence of value-bearing sensitive keys.Current exact state
4d72fda8e3df41e6b4a9f81e3000895a446548b4feat/hr-workspace-protected-read-state@b3b30058a79174000919d566fbbb1fdad80c62bfc92749cf5889a39de1ba8036742f96fd3451f459; therefore this child is intentionally stale relative to the live parent and must not inherit the parent's newer evidenceHR Workspace Job Grade Review State Qualityrun33283652359, check/job99182956631(Job grade review state contract): terminal SUCCESS on4d72fda8e3df41e6b4a9f81e3000895a446548b4Any predecessor-head GREEN/check/review evidence is historical and non-transferable.
Governed interaction contract
The governed states are
idle,loading,review,recording,recorded,denied,stale, anderror. In-flight states are busy and duplicate-submit disabled.reviewandrecordedremain read-only/human-review evidence and explicitly do not authorize compensation, promotion, assignment, candidate, or employment decisions. Denial/stale/failure states use assertive alerts and always provide a safe next action. State evidence never carries Person/candidate identity, contact data, compensation/salary/rating/assessment values, credentials/tokens, prompts, or model output.Storybook reuses Figma
Orgmetra BaselineStorybook Inventory node1:64and existing Orgmetra design/focus tokens. WAI-ARIA 1.2 and WCAG 2.2 primary references plus protected-main/active-PR ownership distinctions are recorded underdocs/doctoringanddocs/traceability.Dependency discipline
Keep Draft. Process #53 → #130 first. Because #130 has advanced beyond this child's recorded base, do not restack merely to manufacture fresh CI while the dependency root remains unintegrated. After those dependencies actually integrate, retarget/revalidate this child against fresh protected
develop, reconcile intervening HR Workspace changes, and rerun every applicable browser/accessibility/Foundation/SAST/Security/Recovery/central workflow on one resulting exact head. This focused GREEN is stack-local and does not transfer parent checks or reviews.Do not self-approve, use routine administrator bypass, race another lifecycle writer, infer compensation or employment-decision authority from UI state, transfer predecessor evidence, create no-op evidence churn, or mutate a dedicated-writer dependency.