Skip to content

feat(reports): leftover expected on grouping comparison graphic (v2.74.0) - #857

Draft
seonghobae wants to merge 3 commits into
feat/leftover-map-compare-plot-observed-v2730from
feat/leftover-map-compare-plot-expected-v2740
Draft

feat(reports): leftover expected on grouping comparison graphic (v2.74.0)#857
seonghobae wants to merge 3 commits into
feat/leftover-map-compare-plot-observed-v2730from
feat/leftover-map-compare-plot-expected-v2740

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Caption persisted leftover expected E on the grouping comparison leftover-map graphic (ADR 0317 / v2.74.0) without inventing scores or new columns. The comparison accessible name stays distinct from period-report and strip copy; missing/non-finite E omits only this caption. Finite negative E remains visible.

Current stack authority

Foundation ordering

The previous #857 repair staging automation/857-adr-status-repair-20260906@76f01f7b7dfa8e37e78c66241f1dee7bc2a8f0d3 / run 34011167801 started from the old #856 parent and is now stale even if it later turns GREEN. Do not promote that tree.

First finish and promote #856's causal ADR0316 repair. Then reconstruct #857 non-force on that exact repaired parent, preserving the expected-caption delta plus #857 governance regression, repair ADR0317 to Proposed in the reconstructed tree, and regenerate tests/evidence. Direct descendant #858 remains downstream of #857; its reconstruction must wait for this foundation chain.

Keep Draft. Do not force-push, self-approve, weaken gates, transfer predecessor GREEN, or choose either divergent tree wholesale.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 9f34d2c stacked on #856 @ c7a8680. Comparison graphic leftover expected uses leftover map comparison graphic leftover expected {label} so it stays distinct from hyphen leftover expected {label} and strip Leftover map comparison expected. Independent APPROVE required on this leftover-expected increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover-map rank on this comparison graphic (ADR 0318 / v2.75.0), stacked here — not mixed into #74/#92.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 08:19 KST: exact head 9f34d2c (v2.74.0 / ADR 0317 leftover expected on grouping comparison leftover-map graphic). Stacked on #856. Independent APPROVE still required. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment: leftover-map rank on this comparison graphic (ADR 0318 / v2.75.0).

…4.0)

Name leftover expected E on grouping comparison leftover-map pair
segments (ADR 0317). After make seed, closest and farthest leftover
pairs sit above the member list with leftover expected E next to
leftover observed Y on that comparison graphic; click opens that post.
Rank-0 unused axes still name E 0.00 when that persisted leftover
expected is finite. A missing or non-finite E omits that leftover-map
comparison graphic leftover expected caption and keeps leftover observed Y.
Never invent a leftover score. Never invent a theta.
@seonghobae
seonghobae force-pushed the feat/leftover-map-compare-plot-expected-v2740 branch from 9f34d2c to ade9ed5 Compare August 31, 2026 00:06

Copy link
Copy Markdown
Contributor Author

Rebased onto #856 @ cf3b6d4 after the leftover observed a11y rename. Head is now ade9ed5.

Comparison-graphic leftover expected uses distinct accessible name leftover map comparison graphic leftover expected {label} (same leftover-qualifier pattern as residual and observed). Vietnamese copy names the leftover map. Local oxlint 0; 511 tests passed (App 103, LeftoverMapPlot 58, leftoverMapPlotLayout 59, i18n 276, leftoverObservedExpected 10, leftoverResidual 5).

Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover-map rank on the comparison graphic (ADR 0318 / v2.75.0).

Copy link
Copy Markdown
Contributor Author

Independent APPROVE still required on this leftover-expected head 9f34d2c (v2.74.0). #858 leftover-map rank (v2.75.0) is stacked here at 4b9184f. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:05
Adopt the conflict-free GitHub test-merge tree for exact parent #856 dbb3079 while preserving existing #857 product head ade9ed5 as first-parent ancestry. No force push and no product delta is dropped.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head repair finding: ADR 0317 is introduced by this still-Draft PR as Decision status: Accepted. That overstates decision authority before independent review/normal merge. Keep the product/UI delta, but make ADR 0317 Proposed on this branch and add an executable regression that prevents the Draft decision from silently returning to Accepted. Also refresh the Stack authority: the live base is #856 at dbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14 and the live head is 2c256e58e08b082b7936b99f3d1481f2f3bc833e, not the older SHAs in the body. Do not force-push or weaken gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant