feat(reports): leftover expected on grouping comparison graphic (v2.74.0) - #857
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
|
Cycle 2026-08-31 08:19 KST: exact head |
…4.0) Name leftover expected E on grouping comparison leftover-map pair segments (ADR 0317). After make seed, closest and farthest leftover pairs sit above the member list with leftover expected E next to leftover observed Y on that comparison graphic; click opens that post. Rank-0 unused axes still name E 0.00 when that persisted leftover expected is finite. A missing or non-finite E omits that leftover-map comparison graphic leftover expected caption and keeps leftover observed Y. Never invent a leftover score. Never invent a theta.
9f34d2c to
ade9ed5
Compare
|
Rebased onto #856 @ Comparison-graphic leftover expected uses distinct accessible name Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover-map rank on the comparison graphic (ADR 0318 / v2.75.0). |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head repair finding: ADR 0317 is introduced by this still-Draft PR as Decision status: Accepted. That overstates decision authority before independent review/normal merge. Keep the product/UI delta, but make ADR 0317 Proposed on this branch and add an executable regression that prevents the Draft decision from silently returning to Accepted. Also refresh the Stack authority: the live base is #856 at dbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14 and the live head is 2c256e58e08b082b7936b99f3d1481f2f3bc833e, not the older SHAs in the body. Do not force-push or weaken gates.
Summary
Caption persisted leftover expected E on the grouping comparison leftover-map graphic (ADR 0317 / v2.74.0) without inventing scores or new columns. The comparison accessible name stays distinct from period-report and strip copy; missing/non-finite E omits only this caption. Finite negative E remains visible.
Current stack authority
974109a055573e3534f4e653fc9929ffad1ac8d8after feat(reports): leftover observed on grouping comparison graphic (v2.73.0) #856 gained its own realistic governance RED for premature ADR 0316 acceptance.549441180e713aba5c4199efc15a44f1c3c11a29; exact compare to the moved parent is now diverged, ahead 3 / behind 1, with merge base the previous feat(reports): leftover observed on grouping comparison graphic (v2.73.0) #856 headdbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14.5124088708separately found ADR 0317 prematurely Accepted.tests/test_adr_0317_governance.pyis an intentional RED requiring Proposed while Draft.Foundation ordering
The previous #857 repair staging
automation/857-adr-status-repair-20260906@76f01f7b7dfa8e37e78c66241f1dee7bc2a8f0d3/ run34011167801started from the old #856 parent and is now stale even if it later turns GREEN. Do not promote that tree.First finish and promote #856's causal ADR0316 repair. Then reconstruct #857 non-force on that exact repaired parent, preserving the expected-caption delta plus #857 governance regression, repair ADR0317 to Proposed in the reconstructed tree, and regenerate tests/evidence. Direct descendant #858 remains downstream of #857; its reconstruction must wait for this foundation chain.
Keep Draft. Do not force-push, self-approve, weaken gates, transfer predecessor GREEN, or choose either divergent tree wholesale.