feat(reports): leftover observed on grouping comparison graphic (v2.73.0) by seonghobae · Pull Request #856 · ContextualWisdomLab/LineageWeave

seonghobae · 2026-08-30T23:54:13Z

Summary

Caption persisted leftover observed Y on the grouping comparison leftover-map graphic (ADR 0316 / v2.73.0) without inventing scores or new columns.
The comparison accessible name remains distinct from period-report and strip copy; missing/non-finite Y omits only this caption while neighbouring independently valid statistics remain available.
Finite negative Y is shown and rank-0 origin cells keep Y 0.00 when persisted Y is finite. Do not derive Y from R/E, coordinates, rank, axis share, coverage, pair counts, or any neighbouring value.

Current stack authority

Live base: feat(reports): leftover residual on grouping comparison graphic (v2.72.0) #855 feat/leftover-map-compare-plot-residual-v2720@e8f0ca2c10584fad578c4cd7e6493025bd565020.
Current feat(reports): leftover observed on grouping comparison graphic (v2.73.0) #856 product head: 974109a055573e3534f4e653fc9929ffad1ac8d8; PR remains Draft and now diverges from the moved parent.
feat(reports): leftover residual on grouping comparison graphic (v2.72.0) #855 moved non-force to add governing RED tests/test_adr_0315_governance.py; its ADR 0315 is intentionally RED until the parent status repair is verified and promoted. Foundation repair therefore precedes any feat(reports): leftover observed on grouping comparison graphic (v2.73.0) #856 reconstruction.
Review 5124096767 found ADR 0316 prematurely declares Decision status: Accepted; tests/test_adr_0316_governance.py requires Proposed while unmerged.

Stale repair evidence boundary

The existing isolated #856 lane automation/856-adr-status-repair-20260906@4bb04c897e06ca389daa2e121a30007ce4f6f5aa, run 34011364534, was created from the previous #855 parent snapshot. Even if it later completes GREEN, it is not promotable after the parent moved. Do not fast-forward #856 from that tree or transfer its checks.

Correct ordering is now: finish #855 ADR0315 Proposed repair on the unchanged parent head → promote its clean tree non-force → reconstruct #856 from that exact repaired #855 while preserving the v2.73/ADR0316 observed-Y delta and applying ADR0316 Proposed → rerun exact child contracts → continue to #857 and descendants. This keeps both valid product deltas and avoids rebuilding descendants on an intentional-RED foundation.

Keep Draft. Do not force-push, self-approve, weaken gates, close valid deltas, or transfer predecessor checks/approval.

coderabbitai · 2026-08-30T23:54:20Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-30T23:54:26Z

Cycle 2026-08-31 08:52 KST: exact head 1a2f11cf (v2.73.0 / ADR 0316 leftover observed on grouping comparison leftover-map graphic). Stacked on #855 @ 4ffed4ae. Independent APPROVE required. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Copilot review requested this cycle. Next buyer increment: leftover expected E on that comparison graphic (ADR 0317 / v2.74.0).

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

seonghobae · 2026-08-30T23:55:57Z

Exact head now c7a8680 stacked on #855 @ 1087b16 (v2.72.0 leftover residual a11y name). Comparison graphic leftover observed uses leftover map comparison graphic leftover observed {label} so it stays distinct from hyphen leftover observed {label} and strip Leftover map comparison observed. Independent APPROVE still required on this leftover-observed increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover expected E on this comparison graphic (ADR 0317 / v2.74.0), stacked here — not mixed into #74/#92.

…3.0) Name leftover observed Y on grouping comparison leftover-map pair segments (ADR 0316). After make seed, closest and farthest leftover pairs sit above the member list with leftover observed Y next to leftover residual R on that comparison graphic; click opens that post. Rank-0 unused axes still name Y 0.00 when that persisted leftover observed is finite. A missing or non-finite Y omits that leftover-map comparison graphic observed caption and keeps leftover residual R. Never invent a leftover score. Never invent a theta.

seonghobae · 2026-08-31T00:01:06Z

Rebased onto #855 @ 1087b16 after the leftover residual a11y rename. Head is now cf3b6d4.

Comparison-graphic leftover observed uses distinct accessible name leftover map comparison graphic leftover observed {label} (same leftover-qualifier pattern as residual). Vietnamese copy names the leftover map. Local oxlint 0; 502 tests passed (App 103, LeftoverMapPlot 55, leftoverMapPlotLayout 58, i18n 272, leftoverObservedExpected 9, leftoverResidual 5).

Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover expected E on the comparison graphic (ADR 0317 / v2.74.0).

seonghobae · 2026-08-31T00:01:39Z

Independent APPROVE still required on this leftover-observed head c7a8680 (v2.73.0). #857 leftover expected (v2.74.0) is stacked here at 9f34d2c. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

devin-ai-integration

Devin Review found 2 new potential issues.

devin-ai-integration · 2026-08-31T00:01:46Z

+                  aria-label={tf(
+                    variant === "comparison"
+                      ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED
+                      : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED,
+                    { label: segment.observedLabel },
+                  )}


📝 Info: Observed values remain data-backed

observedLabel still uses persisted observed_response through its finite-value formatter. The variant branch changes only the accessible name, preserving independent omission.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T00:01:47Z

+                  aria-label={tf(
+                    variant === "comparison"
+                      ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED
+                      : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED,
+                    { label: segment.observedLabel },
+                  )}


📝 Info: Plot variants keep separate labels

The comparison branch receives the new translation key. Report plots retain LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED, so their accessible contract stays unchanged.

Was this helpful? React with 👍 or 👎 to provide feedback.

seonghobae · 2026-08-31T00:03:55Z

Cycle 2026-08-31 08:19 KST: exact head cf3b6d4 (v2.73.0 / ADR 0316 leftover observed on grouping comparison leftover-map graphic). Independent APPROVE still required on this leftover-map stack before any squash-merge. Do not self-approve. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Next buyer increment is leftover-map rank on this comparison graphic after leftover expected (#857 / ADR 0317 / v2.74.0).

Adopt the conflict-free GitHub test-merge tree for exact parent #855 e38c7ca while preserving existing #856 product head cf3b6d4 as first-parent ancestry. No force push and no product delta is dropped.

Adopt the conflict-free GitHub test-merge tree for exact parent #856 dbb3079 while preserving existing #857 product head ade9ed5 as first-parent ancestry. No force push and no product delta is dropped.

seonghobae

Current-head repair finding: ADR 0316 is introduced by this still-Draft PR as Decision status: Accepted. That is premature decision authority before qualifying independent review/normal merge. Preserve the observed-caption product/UI delta, but keep ADR 0316 Proposed while this PR is Draft and add an executable governance regression. The PR body is also stale: live base is #855 at e38c7caf45ed51825eba73047f78052e8d51a431 and live head is dbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14, not the abbreviated older Stack line. No force-push, self-approval, or gate weakening.

devin-ai-integration Bot reviewed Aug 30, 2026

View reviewed changes

seonghobae force-pushed the feat/leftover-map-compare-plot-observed-v2730 branch from 1a2f11c to c7a8680 Compare August 30, 2026 23:55

seonghobae mentioned this pull request Aug 30, 2026

feat(reports): leftover residual on grouping comparison graphic (v2.72.0) #855

Draft

seonghobae force-pushed the feat/leftover-map-compare-plot-observed-v2730 branch from c7a8680 to cf3b6d4 Compare August 31, 2026 00:00

seonghobae mentioned this pull request Aug 31, 2026

feat(reports): leftover expected on grouping comparison graphic (v2.74.0) #857

Draft

devin-ai-integration Bot reviewed Aug 31, 2026

View reviewed changes

seonghobae marked this pull request as draft September 4, 2026 08:05

chore(stack): converge #856 onto current #855

dbb3079

Adopt the conflict-free GitHub test-merge tree for exact parent #855 e38c7ca while preserving existing #856 product head cf3b6d4 as first-parent ancestry. No force push and no product delta is dropped.

seonghobae commented Sep 6, 2026

View reviewed changes

test(adr): keep draft 0316 proposed

974109a

seonghobae added a commit that referenced this pull request Sep 6, 2026

ci(repair): stage #856 ADR status fix

4bb04c8

seonghobae added enhancement New feature or request priority: medium status: draft type: feature labels Sep 7, 2026 — with ChatGPT Codex Connector

Navigation Menu

Uh oh!

feat(reports): leftover observed on grouping comparison graphic (v2.73.0) - #856

feat(reports): leftover observed on grouping comparison graphic (v2.73.0)#856
seonghobae wants to merge 3 commits into
feat/leftover-map-compare-plot-residual-v2720from
feat/leftover-map-compare-plot-observed-v2730

seonghobae commented Aug 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 30, 2026 •

edited

Loading

Draft PR not reviewed

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

devin-ai-integration Bot left a comment •

edited

Loading

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Current stack authority

Stale repair evidence boundary

Uh oh!

coderabbitai Bot commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 30, 2026 •

edited

Loading

coderabbitai Bot commented Aug 30, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading