feat(reports): leftover-map rank on grouping comparison graphic (v2.75.0) - #858
Conversation
…3.0)
Caption persisted leftover observed Y on the grouping
comparison leftover-map graphic from already-named observed_response
(ADR 0316). Comparison copy uses leftover map comparison graphic leftover
observed {label} so it stays distinct from leftover observed {label}
and from strip Leftover map comparison observed.
A missing or non-finite Y omits that caption and keeps leftover residual,
leftover-map unexplained leftover, leftover-map cross share, leftover-map
unexplained leftover share, leftover-map explained leftover share,
leftover-map reconstruction, leftover-map distance, and comparison graphic
coverage notes. Rank-0 origin cells still name Y 0.00 when that leftover
is finite. Do not caption leftover expected this increment. Do not invent
Y from R and E or leftover residual. Never invent a leftover score.
Never invent a theta. No new columns.
…4.0)
Caption persisted leftover expected E on the grouping
comparison leftover-map graphic from already-named expected_response
(ADR 0317). Comparison copy uses leftover map comparison graphic leftover
expected {label} so it stays distinct from leftover expected {label}
and from strip Leftover map comparison expected.
A missing or non-finite E omits that caption and keeps leftover observed,
leftover residual, leftover-map unexplained leftover, leftover-map cross
share, leftover-map reconstruction, leftover-map distance, and comparison
graphic coverage notes. Rank-0 origin cells still name E 0.00 when that
leftover is finite. Do not caption leftover-map rank this increment.
Do not invent E from Y and R. Never invent a leftover score.
Never invent a theta. No new columns.
…5.0)
Caption persisted leftover-map rank on the grouping
comparison leftover-map graphic from already-named leftover_map_rank
(ADR 0318). Comparison copy uses leftover map comparison graphic leftover-map
rank {label} so it stays distinct from leftover-map rank {label}
and from strip Leftover map comparison rank.
A missing, negative, or non-integer rank omits that caption and keeps leftover expected,
leftover observed, leftover residual, leftover-map unexplained leftover, leftover-map cross
share, leftover-map reconstruction, leftover-map distance, and comparison
graphic coverage notes. Rank-0 origin cells still name rank 0 when that
leftover-map rank is a non-negative integer. Do not caption leftover-map distance this increment.
Do not invent leftover-map rank from plotted coordinates or leftover-map distance. Never invent a leftover score.
Never invent a theta. No new columns.
|
Exact head |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| x={segment.rankX} | ||
| y={segment.rankY} | ||
| textAnchor="middle" | ||
| aria-label={tf(LEFTOVER_MAP_PLOT_SEGMENT_RANK, { | ||
| label: segment.rankLabel, | ||
| })} | ||
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_RANK | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_RANK, | ||
| { label: segment.rankLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Shared layout remains unchanged
variant changes only the three accessible-name templates. Formatting, omission rules, and stacked positions still use the existing shared layout.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_RANK = | ||
| "leftover map comparison graphic leftover-map rank {label}"; |
There was a problem hiding this comment.
📝 Info: Rank omission stays centralized
The shared formatLeftoverMapRank rejects missing, negative, fractional, and non-finite values before either plot renders a caption. Zero remains valid.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Independent APPROVE required on exact head |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-parent reconstruction finding: the base now correctly points to #857 2c256e58e08b082b7936b99f3d1481f2f3bc833e, but this child cannot use the conflict-free two-parent adoption pattern used for #844–#857. GitHub produces no current test-merge SHA. Exact compare is ahead 3 / behind 45 with merge base old #855 1087b16f...; the branch replays old observed c7a8680f..., old expected 9f34d2cb..., then rank 4b9184fd... instead of being a one-delta child of current #857. Current #857 differs from its old ade9ed5... product head only by inherited foundation/version-test files, but old expected 9f34d2cb... and ade9ed5... themselves diverge materially across AGENTS/ARCHITECTURE/ADR/i18n/plot tests and implementation. Therefore copying the rank commit's whole-file blobs would discard valid current-parent content and is prohibited. Preserve ADR 0318/rank behavior, keep Draft, and reconstruct the rank delta onto exact #857 rather than selecting either old tree wholesale. No force rebase and no predecessor GREEN transfer.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Caption persisted leftover-map rank on the grouping comparison leftover-map graphic from already-named
leftover_map_rank(ADR 0318 / v2.75.0).Live authority
#857@549441180e713aba5c4199efc15a44f1c3c11a294b9184fd83f6749e25384d7bcf5d9d7721437b771087b16f2dba743bc0d1d4e08ff50811b58453935123611005records the rank reconstruction findingThis branch is not a one-delta child of current #857. Its history replays old observed, old expected, then rank, while current #857 owns materially newer expected/ADR/docs/i18n/plot/test content. Selecting the old #858 tree wholesale would discard valid current-parent content. Force rebasing or choosing one side's files wholesale is prohibited.
The previous reconstruction RED
automation/858-rank-reconstruction-red-20260906@bde3776fb8d2b16a3c9af780a30541d3796acfecis now stale because #857 moved from2c256e58…to549441180…. #857's movement is a deliberate realistic governance RED for premature ADR 0317 acceptance; its isolated causal repair must become GREEN and be promoted first. Retargeting this PR to current #857 is complete, but reconstructing rank on a knowingly RED parent would create another stale successor, so the old reconstruction evidence must not be promoted or reused as GREEN.Product invariant
Comparison copy uses
leftover map comparison graphic leftover-map rank {label}so it stays distinct fromleftover-map rank {label}and from stripLeftover map comparison rank. A missing, negative, or non-integer rank omits that caption and keeps leftover expectedE. Rank-0 origin cells still namerank 0when that persisted leftover-map rank is a non-negative integer. Do not invent rank from plotted coordinates or distance; never invent a leftover score or theta; no new columns.Keep Draft. After #857's ADR-status repair is promoted, reconstruct the rank delta non-force onto that exact GREEN parent while preserving the parent governance regression and current observed/expected semantics. Required exact-head GREEN and independent approval must be regenerated after reconstruction; predecessor checks do not transfer.