feat(reports): leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0) - #852
Conversation
…mparison graphic (v2.69.0)
Caption persisted leftover-map unexplained leftover share s on the grouping
comparison leftover-map graphic from already-named leftover_map_unexplained_share
(ADR 0312). Comparison copy uses leftover map comparison graphic unexplained
leftover share {label} so it stays distinct from hyphen leftover-map unexplained
leftover share {label} and from strip Leftover map comparison unexplained leftover
share. A missing or non-finite s omits that caption and keeps leftover-map
explained leftover share, leftover-map reconstruction, leftover-map distance,
and comparison graphic coverage notes. Rank-0 origin cells still name U²/R² 0.00
when that share is finite. Do not caption leftover-map cross share this increment.
Do not invent s from U and R or leftover-map distance. Never invent a leftover
score. Never invent a theta. No new columns.
|
Queue retry: leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0 / ADR 0312) @ Verification: vitest 808 passed, oxlint 0, py_compile ok. Next stacked increment is leftover-map cross share on that comparison graphic. Issues #79 and #87 stay open. #96 is already closed. Do not merge #808 without independent APPROVE. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Queue retry: leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0 / ADR 0312). Independent APPROVE required before squash-merge. Do not self-approve. Next stacked increment is leftover-map cross share on that comparison graphic. Issues #79 and #87 stay open. #96 is already closed. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_UNEXPLAINED_SHARE, | ||
| { label: segment.unexplainedShareLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Variant switch preserves omission behavior
LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE changes only the accessible name. Missing shares still omit independently because rendering remains gated by the existing formatter.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "leftover map comparison graphic explained leftover share {label}": | ||
| "잔여 지도 비교 그림 설명 잔여 점유율 {label}", | ||
| "Leftover map comparison explained leftover share": "잔여 지도 비교 설명 잔여 점유율", | ||
| "leftover map comparison graphic unexplained leftover share {label}": "잔여 지도 비교 그림 미설명 잔여 점유율 {label}", |
There was a problem hiding this comment.
📝 Info: Translations follow runtime lookup order
Every non-English locale defines the new key. English safely uses the key itself before tf substitutes the formatted persisted value.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31T06:40 KST: writes work. Independent APPROVE still required; not self-approving. Local duplicate of this increment was 8d3085c on a shallow clone of #851 and was not force-pushed. Next buyer gap after this head: leftover-map cross share on the grouping comparison leftover-map graphic (ADR 0313 / v2.70.0). |
|
Cycle retry (2026-08-31T07:08 KST): write-scope probe. Independent APPROVE still required; not self-approving. |
|
Queue retry 2026-08-31T07:21 KST: leftover-map unexplained leftover share on grouping comparison graphic remains stacked at v2.69.0. Independent APPROVE required on exact head 2c34896. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Next buyer gap is leftover-map cross share on the grouping comparison graphic (distinct comparison-graphic name; strip already has ADR 0296). |
|
Cycle 2026-08-31 ~07:08 KST: writes retry. Head |
|
Stacked buyer increment opened: leftover-map cross share on grouping comparison leftover-map graphic (v2.70.0 / ADR 0313) is #853 @ |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption persisted leftover-map unexplained leftover share
son the grouping-comparison leftover-map graphic whenformatLeftoverMapUnexplainedSharereturns a usable badge (ADR 0312 / v2.69.0). It omits independently from explained share, reconstruction, distance, and coverage. No SQL/new columns; never derivesfromU/Ror neighbouring statistics.Live authority
#851@72df615a8fb1350217039c6a62007243a6322ccc80b9254aea2177f2bb506acf0370688df424a036Parent convergence
#852 inherited the ADR-governance regression as
ed6502e2b214b8a1d6c3463d8febb32a049028e5. GitHub generated exact current-parent merge27c2330729414736a6f8fb5af9d8ffbf9ae0c35c, verified with parents#851@72df615a...and#852@ed6502e2...; the merge tree preserves ADR 0312/v2.69.0 while carrying ADR 0304Proposed. That tree was recorded child-first as80b9254a...; branch movement was non-force only.Historical
808frontend tests/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y, PostgreSQL/k6 evidence, and independent approval remain outstanding. Direct descendants must be reconstructed before predecessor evidence transfers.Product invariants
somits only its graphic caption; values above 1 remain visible and are not clamped.Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.