feat: broadcast proposer preferences before the gloas fork#9571
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ProposerPreferencesService to enable broadcasting proposer preferences prior to the Gloas fork, ensuring caches are warm for the initial Gloas slots. The task now initiates when the submission window (slot + SUBMIT_BEFORE_PROPOSAL_SLOTS) reaches Gloas, and a check has been added to skip duties that are not post-Gloas. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af6acda441
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Start running once the submission window (`slot + SUBMIT_BEFORE_PROPOSAL_SLOTS`) reaches | ||
| // Gloas, i.e. already in the epoch before the fork. This allows builders to prepare and | ||
| // submit bids for the first Gloas slots. | ||
| if (!isForkPostGloas(this.config.getForkName(slot + SUBMIT_BEFORE_PROPOSAL_SLOTS))) { |
There was a problem hiding this comment.
Once this pre-fork path is enabled, the task consumes getProposersAtEpoch(currentEpoch + 1) while the clock is still in the final pre-Gloas epoch. I checked BlockDutiesService.onNewHead: in the pre-Gloas branch it only refetches currentEpoch, so if a reorg changes the dependent root for the upcoming Gloas epoch after the epoch-start prefetch, the cached Gloas duties remain under the old root. In that scenario these early submissions are signed with a stale dependentRoot, causing the beacon node to ignore/reject them and leaving builders without valid preferences for the first Gloas slots.
Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment.
but I don't think this edge case is worth handling, a reorg in the last SUBMIT_BEFORE_PROPOSAL_SLOTS of the pre-gloas epoch is very unlikely and we will still submit correctly at slot 0 of gloas
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This was referenced Jul 4, 2026
nflaig
added a commit
that referenced
this pull request
Jul 6, 2026
### Motivation Follow-up to #9571. The `submitted` map in `ProposerPreferencesService` tracks which preferences were sent per epoch but was never pruned, so it grows by one entry each epoch for the lifetime of the process. Raised in review by @twoeths. ### Description Drop tracking for past epochs at the start of each task run; only `currentEpoch` and `currentEpoch + 1` are ever processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per ethereum/beacon-APIs#608
Also related to ethereum/consensus-specs#4947 but we already do this since we subscribe to new gossip topics 2 epochs before the fork (
SUBSCRIPTIONS_LOOKAHEAD_EPOCHS = 2).