fix: prune old proposer preferences submissions#9591
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to prune past epochs from the submitted tracking map in ProposerPreferencesService, preventing unbounded memory growth. It also adds a corresponding unit test to verify that past epochs are correctly deleted while the current epoch is retained. There are no review comments, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
nflaig
force-pushed
the
nflaig/prune-proposer-preferences
branch
from
d48f2b3 to
7583a02
Compare
nflaig
force-pushed
the
nflaig/prune-proposer-preferences
branch
from
7583a02 to
0fb52bb
Compare
nflaig
commented
Jul 4, 2026
nflaig
left a comment
nflaig
left a comment
Member
Author
There was a problem hiding this comment.
LGTM, self-review since this was implemented by claude
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #9571. The
submittedmap inProposerPreferencesServicetracks which preferences were sent per epoch but was never pruned, so it grows by one entry each epoch for the lifetime of the process. Raised in review by @twoeths.Description
Drop tracking for past epochs at the start of each task run; only
currentEpochandcurrentEpoch + 1are ever processed.