-
-
Notifications
You must be signed in to change notification settings - Fork 464
feat: broadcast proposer preferences before the gloas fork #9571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nflaig
merged 1 commit into
unstable
from
nflaig/proposer-preferences-pre-fork-submission
Jul 4, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this pre-fork path is enabled, the task consumes
getProposersAtEpoch(currentEpoch + 1)while the clock is still in the final pre-Gloas epoch. I checkedBlockDutiesService.onNewHead: in the pre-Gloas branch it only refetchescurrentEpoch, so if a reorg changes the dependent root for the upcoming Gloas epoch after the epoch-start prefetch, the cached Gloas duties remain under the old root. In that scenario these early submissions are signed with a staledependentRoot, causing the beacon node to ignore/reject them and leaving builders without valid preferences for the first Gloas slots.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I don't think this edge case is worth handling, a reorg in the last
SUBMIT_BEFORE_PROPOSAL_SLOTSof the pre-gloas epoch is very unlikely and we will still submit correctly at slot 0 of gloas