fix: refresh next-epoch proposer duties before the gloas fork#9590
Closed
nflaig wants to merge 1 commit into
Closed
fix: refresh next-epoch proposer duties before the gloas fork#9590nflaig wants to merge 1 commit into
nflaig wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BlockDutiesService to re-poll next-epoch proposer duties on every slot during the final pre-Gloas epoch. This ensures that proposer preferences remain fresh and any dependent root shifts (e.g., due to a reorg) are picked up, since the v1 head event does not expose the next-epoch dependent root. A unit test has been added to verify this behavior. The reviewer pointed out that on the first slot of the final pre-Gloas epoch, runEveryEpochTask already pre-fetches the upcoming Gloas epoch duties, making the call in runEverySlotTask redundant on that slot. A suggestion was provided to skip the first slot of the epoch to avoid duplicate API requests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+186
to
+189
| } else if ( | ||
| !isForkPostGloas(this.config.getForkName(slot)) && | ||
| isForkPostGloas(this.config.getForkName(nextEpochStartSlot)) | ||
| ) { |
Contributor
There was a problem hiding this comment.
At the start of the final pre-Gloas epoch (the first slot of the epoch), runEveryEpochTask already pre-fetches the upcoming Gloas epoch duties via pollBeaconProposers(nextEpoch). Calling pollBeaconProposers(nextEpoch) again in runEverySlotTask on the very first slot results in a redundant concurrent API request to the beacon node.
We can avoid this redundant call by ensuring we do not re-poll on the first slot of the epoch.
Suggested change
| } else if ( | |
| !isForkPostGloas(this.config.getForkName(slot)) && | |
| isForkPostGloas(this.config.getForkName(nextEpochStartSlot)) | |
| ) { | |
| } else if ( | |
| slot !== computeStartSlotAtEpoch(computeEpochAtSlot(slot)) && | |
| !isForkPostGloas(this.config.getForkName(slot)) && | |
| isForkPostGloas(this.config.getForkName(nextEpochStartSlot)) | |
| ) { |
Member
Author
I had claude open this PR because of #9571 (comment) but this is not something we should worry about gonna close this again |
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #9571. In the final pre-Gloas epoch the validator submits proposer preferences for the first Gloas slots, which reads the next epoch's proposer duties from
BlockDutiesService. Pre-Gloas,onNewHeadcannot reorg-refresh those duties since the v1 head event does not expose the next-epoch proposer dep_root, and the boundary poll only fetches the next epoch when it is still pre-Gloas. A reorg in the lastSUBMIT_BEFORE_PROPOSAL_SLOTSthat shifts the Gloas epoch's dep_root therefore leaves the cached duties stale, the resubmit-on-shift check never fires, and the preferences go out under a stale dep_root which the beacon node ignores.Description
Re-poll the next epoch each slot during the final pre-Gloas epoch so a dep_root shift is picked up and the pre-fork preferences resubmit under the current root.