Repository navigation
React migration 1/6: foundation app in react-app/ - #938
Open
devin-ai-integration[bot] wants to merge 4 commits into
Open
devin-ai-integration[bot] wants to merge 4 commits into
devin-ai-integration[bot] wants to merge 4 commits into
Conversation
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
There was a problem hiding this comment.
Devin Review found 1 finding. Devin automatically fixed it.
Fixed by Devin (1)
- Failed poll option hides entire item — Real regression vs Angular (which subscribed per option): a single failed option rejected the whole item. Now uses Promise.allSettled, keeps failed entries and sums only loaded votes; added a test.
This was referenced Nov 11, 2026
Author
This was referenced Nov 11, 2026
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of six PRs migrating angular2-hn from Angular to React. This one only adds files: it creates a standalone React 19 + TypeScript + Vite app in
react-app/and leaves the Angular app and its build untouched. That means it can merge by itself.What it ports from Angular:
src/models):Story,Comment,User,PollResult,Settings,FEED_TYPES,THEMESsrc/api/hackerNewsApi.ts): replacesHackerNewsAPIService. It usesfetchand supportsAbortSignal, and a non-OK response now throws. Poll options are fetched and their votes summed, as before.fetchUsercallsapi.hnpwa.com/v0/user/:id.jsonbecause node-hnapi's/user/:idnow returns 404. Feeds and items still use node-hnapi.SettingsProvider/useSettings): replacesSettingsServiceand keeps the same localStorage keys (theme,openLinkInNewTab,titleFontSize,listSpacing). If no theme is saved, the system dark-mode preference is used.src/routes.tsx): same asapp.routes.ts, with/→/news/1,:feed/:page, and lazy-loadeditem/:idanduser/:id. The pages are placeholders that later PRs fill in.Loader,ErrorMessage, theme SCSS, and static assets. In the SCSS,/division anddarken()were replaced withmath.divandcolor.adjustso it builds on current Dart Sass..github/workflows/react-app.ymlruns lint, typecheck, vitest (19 tests) and build whenreact-app/**changes.Next PRs: 2 shell, 3 feeds, 4 item details, 5 user profile, 6 cutover (move to repo root, PWA, delete Angular).
This duplicates #932 from an earlier parallel migration stack. Only one of them should land.
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin
Note
Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work