Skip to content

React migration 3/6: feeds (story list, item rows, paging) - #940

Open
devin-ai-integration[bot] wants to merge 5 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-feeds
Open

devin-ai-integration[bot] wants to merge 5 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-feeds

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Summary

This PR ports feeds/feed and feeds/item into react-app/ and replaces the placeholder FeedPage. It is stacked on #938 (foundation) and is independent of #939 (shell).

  • FeedPage calls fetchFeed(feedType, page) in an effect with an AbortController, so a stale page response can't overwrite a newer page. State is keyed by feedType/page, which means a new page shows the loader again, the same as Angular. On failure it shows ErrorMessage("Could not load <feed> stories."). After a page loads it calls window.scrollTo(0, 0). The list start is (page-1)*30+1. ‹ Prev shows when the page isn't the first, and More › shows only when the page has 30 items. The jobs feed gets the YC/Triplebyte header.
  • FeedItem (from item.component):
    • A story whose url starts with http links out and shows its domain. Anything else (ask/show text posts) links to /item/:id.
    • Title font size, list spacing and open-in-new-tab come from useSettings().
    • Jobs hide the points, user and comment links.
    • Like Angular, it has both a mobile (subtext-palm) and a desktop (subtext-laptop) subtext.
  • Angular scoped component styles automatically. React doesn't, so the SCSS is copied and wrapped in .feed / .item-block to keep the old bare a/ol/p selectors from leaking.

FeedPage.test.tsx covers numbering, metadata, comment-count wording, paging both ways, internal vs external links, new-tab links, the jobs layout and the error state. routes.test.tsx now stubs fetch. Lint, typecheck, 25 tests and the build pass.

This duplicates #936 from an earlier parallel migration stack. Only one of them should land.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin


Note

Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.


🟢 Devin fixed all 3 findings · Follow Devin's work

Devin Review

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

…minimal

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
devin-ai-integration Bot and others added 3 commits November 12, 2026 09:53
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…v paging

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 findings. Devin automatically fixed all 3 findings.

Fixed by Devin (3)
  • Overlapping feed requests go untested — Added a held page-1 request test; it exposed that a late resolve after navigation clobbered state and left the page on the loader. FeedPage now ignores results once its request is aborted.
  • Backward paging never runs in test — Paging test now follows ‹ Prev back to page 1 and checks stories, numbering and the hidden Prev link.
  • Job metadata test misses mobile leaks — Jobs test now also asserts no comment-count text and no mobile ★ points row.

View findings in Devin Review · Follow Devin's work

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants