Skip to content

React migration 6/6: cutover to React at repo root, PWA, CI deploy, remove Angular - #943

Open
devin-ai-integration[bot] wants to merge 22 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-cutover
Open

devin-ai-integration[bot] wants to merge 22 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-cutover

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Summary

This is the final step of the migration and should land last. The branch merges #939–#942 (shell, feeds, item, user), so until those land the diff against #938's branch includes them. The cutover-only changes are in commit feature: cut over to React… plus the fixes listed below.

  • Moves the React app to the repo root. react-app/{src,public,index.html,package*.json,vite.config.ts,tsconfig.json,eslint.config.js} → /. It deletes Angular entirely: src/app, e2e/, angular.json, karma.conf.js, tslint.json, tsconfig.{app,spec}.json, browserslist, ngsw-config.json, yarn.lock and the Angular package.json.
  • PWA. vite-plugin-pwa replaces @angular/service-worker. Workbox precaches the app shell and the public/ assets through globPatterns only (28 unique entries), navigateFallback: '/index.html' covers deep links offline, and registerType: 'autoUpdate' is used. includeAssets was removed and includeManifestIcons: false set, because the duplicate icon URLs threw add-to-cache-list-conflicting-entries and stopped the SW from installing. The web manifest is generated from the old src/manifest.json (same name, colors, icons, start_url), and apple-touch and mask icons are added to index.html.
  • Routing. Adds { path: '*', loader: () => redirect('/news/1') }, so unknown URLs land on the front page instead of React Router's default error screen.
  • Hosting and CI. firebase.json is unchanged because Vite also builds to dist/. .travis.yml (Node 6, Angular CLI) is replaced by .github/workflows/ci.yml: lint, typecheck, test and build on every PR and push. On pushes to master it also runs firebase deploy --only hosting --project default, which needs a FIREBASE_TOKEN repo secret, the same name Travis used. Note: the repo's GitHub Actions runs currently sit in queued and never start, so this workflow has only been run locally so far.
  • Tests. A merge exposed two cross-PR test interactions, which are fixed on their own branches so every PR still merges alone. React migration 3/6: feeds (story list, item rows, paging) #940 now stubs fetch by default in test/setup.ts, and React migration 2/6: app shell (header, footer, settings, GA) #939's nav test no longer asserts the placeholder text. Merged-in fixes from the UI test: header styles scoped under #header so feed author links stay visible (React migration 2/6: app shell (header, footer, settings, GA) #939), and fetchUser rejects HNPWA's null body for unknown users (React migration 1/6: foundation app in react-app/ #938).
  • The README and CONTRIBUTING setup steps now describe npm run dev/lint/typecheck/test/build/preview.

Lint, typecheck, 44 tests and npm run build all pass at the root. The full-app browser verification, dev server and production preview including offline, is in the PR comment.

This duplicates #937 from an earlier parallel migration stack. Only one of them should land.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin


Note

Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.


🟢 Devin fixed the finding · Follow Devin's work

Devin Review

devin-ai-integration Bot and others added 15 commits November 11, 2026 20:31
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…minimal

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…ols keyboard-operable

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…origin/devin/task-2-react-user' into devin/task-2-react-cutover
…es the feeds PR

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
… and remove Angular

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@socket-security

socket-security Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addeddompurify@​3.4.171001001009270
Addedvite-plugin-pwa@​1.3.0971009990100

View full report

devin-ai-integration Bot and others added 2 commits November 11, 2026 20:40
… feed rows

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 finding. Devin automatically fixed it.

Fixed by Devin (1)
  • Pageview test uses malformed item fixture — Pageview test now stubs a real item for /item/1 and waits for its title to render, not just the loading wrapper.

View findings in Devin Review · Follow Devin's work

Devin Review

devin-ai-integration Bot and others added 2 commits November 11, 2026 20:47
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

Runtime browser verification (cutover HEAD b9ef104)

Tested locally against live APIs in the Vite dev server and the production npm run preview build, at desktop and mobile widths.

  • ✅ Header nav, settings via mouse and keyboard, Night/AMOLED themes, font size and spacing persisting across reloads, footer
  • ✅ Feed numbering and paging, jobs presentation, external/internal links, author links on desktop and mobile
  • ✅ Item metadata, nested comments collapsing via mouse/Enter/Space, proportional poll bars (/item/40854152), mobile back
  • ✅ Profiles with rendered about HTML; an unknown user now shows an error (HNPWA returns null, fixed in React migration 1/6: foundation app in react-app/ #938)
  • ✅ /foo/bar → /news/1, manifest and icons, sw.js activated, app shell served by the service worker on an offline reload
  • ✅ Online console clean (offline only shows the expected GA network error)
  • ⚠️ Not verified: links actually opening in a new tab, because the test browser strips target. The persisted setting and the _blank/noopener React props were verified.

Fixed during testing: duplicate Workbox precache entries (includeAssets plus manifest icons) blocked SW install; includeManifestIcons: false now leaves 28 unique entries.

Collapsed comment thread Offline shell via service worker Profile
collapsed offline profile

Recording

Written by Devin

devin-ai-integration Bot and others added 3 commits November 12, 2026 09:53
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants