Repository navigation
React migration 6/6: cutover to React at repo root, PWA, CI deploy, remove Angular - #943
Open
devin-ai-integration[bot] wants to merge 22 commits into
Open
devin-ai-integration[bot] wants to merge 22 commits into
devin-ai-integration[bot] wants to merge 22 commits into
Conversation
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…minimal Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…evin/task-2-react-cutover
…vin/task-2-react-cutover
…vin/task-2-react-cutover
…ols keyboard-operable Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…origin/devin/task-2-react-user' into devin/task-2-react-cutover
…es the feeds PR Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
… and remove Angular Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…evin/task-2-react-cutover
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
… feed rows Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
…evin/task-2-react-cutover
Author
There was a problem hiding this comment.
Devin Review found 1 finding. Devin automatically fixed it.
Fixed by Devin (1)
- Pageview test uses malformed item fixture — Pageview test now stubs a real item for /item/1 and waits for its title to render, not just the loading wrapper.
…nto devin/task-2-react-cutover
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
Runtime browser verification (cutover HEAD
|
| Collapsed comment thread | Offline shell via service worker | Profile |
|---|---|---|
![]() |
![]() |
![]() |
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This is the final step of the migration and should land last. The branch merges #939–#942 (shell, feeds, item, user), so until those land the diff against #938's branch includes them. The cutover-only changes are in commit
feature: cut over to React…plus the fixes listed below.react-app/{src,public,index.html,package*.json,vite.config.ts,tsconfig.json,eslint.config.js}→/. It deletes Angular entirely:src/app,e2e/,angular.json,karma.conf.js,tslint.json,tsconfig.{app,spec}.json,browserslist,ngsw-config.json,yarn.lockand the Angularpackage.json.vite-plugin-pwareplaces@angular/service-worker. Workbox precaches the app shell and thepublic/assets throughglobPatternsonly (28 unique entries),navigateFallback: '/index.html'covers deep links offline, andregisterType: 'autoUpdate'is used.includeAssetswas removed andincludeManifestIcons: falseset, because the duplicate icon URLs threwadd-to-cache-list-conflicting-entriesand stopped the SW from installing. The web manifest is generated from the oldsrc/manifest.json(same name, colors, icons,start_url), and apple-touch and mask icons are added toindex.html.{ path: '*', loader: () => redirect('/news/1') }, so unknown URLs land on the front page instead of React Router's default error screen.firebase.jsonis unchanged because Vite also builds todist/..travis.yml(Node 6, Angular CLI) is replaced by.github/workflows/ci.yml: lint, typecheck, test and build on every PR and push. On pushes tomasterit also runsfirebase deploy --only hosting --project default, which needs aFIREBASE_TOKENrepo secret, the same name Travis used. Note: the repo's GitHub Actions runs currently sit inqueuedand never start, so this workflow has only been run locally so far.fetchby default intest/setup.ts, and React migration 2/6: app shell (header, footer, settings, GA) #939's nav test no longer asserts the placeholder text. Merged-in fixes from the UI test: header styles scoped under#headerso feed author links stay visible (React migration 2/6: app shell (header, footer, settings, GA) #939), andfetchUserrejects HNPWA'snullbody for unknown users (React migration 1/6: foundation app in react-app/ #938).npm run dev/lint/typecheck/test/build/preview.Lint, typecheck, 44 tests and
npm run buildall pass at the root. The full-app browser verification, dev server and production preview including offline, is in the PR comment.This duplicates #937 from an earlier parallel migration stack. Only one of them should land.
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin
Note
Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.
🟢 Devin fixed the finding · Follow Devin's work