Skip to content

React migration 2/6: app shell (header, footer, settings, GA) - #939

Open
devin-ai-integration[bot] wants to merge 6 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-shell
Open

devin-ai-integration[bot] wants to merge 6 commits into
devin/task-2-react-foundationfrom
devin/task-2-react-shell

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Summary

This PR ports the Angular core/ shell into the React app in react-app/. It is stacked on #938 (foundation) and only touches react-app/.

  • Header: logo, plus new | show | ask | jobs built with NavLink. React Router's active class stands in for routerLinkActive, and clicking a link calls window.scrollTo(0, 0). The cog icon toggles settings.showSettings.
  • SettingsPanel: the overlay from settings.component, wired to useSettings(). It covers open-links-in-new-tab, the theme radios (default / night / amoledblack), and title font size and list spacing. The number inputs update on onChange rather than Angular's keyup, so the spinner arrows also save.
  • Footer: the GitHub link.
  • usePageViews: one ga('set','page') and one ga('send','pageview') per location change, the same as AppComponent's NavigationEnd hook. The analytics.js snippet (UA-66348622-3) is now in react-app/index.html.
    • / → /news/1 is now a loader redirect() instead of <Navigate>. The redirect resolves before render, so / doesn't send its own pageview; this matches Angular's urlAfterRedirects.
  • SCSS is copied from the Angular components, with @import replaced by @use.

shell.test.tsx covers nav, the active link, the settings flows (theme, links, font, close) and pageview counts. Lint, typecheck, 24 tests and the build pass.

This duplicates #934 from an earlier parallel migration stack. Only one of them should land.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin


Note

Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.


🟢 Devin fixed the finding · Follow Devin's work

Devin Review

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 finding. Devin automatically fixed it.

Fixed by Devin (1)
  • Pageview test accepts other GA hits — Test now asserts both send calls are exactly ['send','pageview'].

View findings in Devin Review · Follow Devin's work

Devin Review

…es the feeds PR

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
devin-ai-integration Bot and others added 3 commits November 11, 2026 20:40
… feed rows

Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants