Repository navigation
React migration 2/6: app shell (header, footer, settings, GA) - #939
Open
devin-ai-integration[bot] wants to merge 6 commits into
Open
devin-ai-integration[bot] wants to merge 6 commits into
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
There was a problem hiding this comment.
Devin Review found 1 finding. Devin automatically fixed it.
Fixed by Devin (1)
- Pageview test accepts other GA hits — Test now asserts both send calls are exactly ['send','pageview'].
This was referenced Nov 11, 2026
…es the feeds PR Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
… feed rows Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the Angular
core/shell into the React app inreact-app/. It is stacked on #938 (foundation) and only touchesreact-app/.Header: logo, plusnew | show | ask | jobsbuilt withNavLink. React Router'sactiveclass stands in forrouterLinkActive, and clicking a link callswindow.scrollTo(0, 0). The cog icon togglessettings.showSettings.SettingsPanel: the overlay fromsettings.component, wired touseSettings(). It covers open-links-in-new-tab, the theme radios (default / night / amoledblack), and title font size and list spacing. The number inputs update ononChangerather than Angular'skeyup, so the spinner arrows also save.Footer: the GitHub link.usePageViews: onega('set','page')and onega('send','pageview')per location change, the same asAppComponent'sNavigationEndhook. The analytics.js snippet (UA-66348622-3) is now inreact-app/index.html./→/news/1is now a loaderredirect()instead of<Navigate>. The redirect resolves before render, so/doesn't send its own pageview; this matches Angular'surlAfterRedirects.@importreplaced by@use.shell.test.tsxcovers nav, the active link, the settings flows (theme, links, font, close) and pageview counts. Lint, typecheck, 24 tests and the build pass.This duplicates #934 from an earlier parallel migration stack. Only one of them should land.
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/a08488aa0df94f1ba5fcd309e7df132d
Link to Bot: https://devin-gtm.devinenterprise.com/org/devin-gtm/bots/a78446fd2653463e94cefb31caca525b
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/a08488aa0df94f1ba5fcd309e7df132d?variant=devin
Note
Devin could not open this Pull Request as matthewguerra-cog: they have no GitHub connection usable for this repository.
As a fallback, Devin opened this PR as itself.
🟢 Devin fixed the finding · Follow Devin's work