Repository navigation
feature: Angular 21.2.4 + ESLint, Vitest CI workflow, gh-release v2, network-free health test - #55
Open
devin-ai-integration[bot] wants to merge 8 commits into
Open
devin-ai-integration[bot] wants to merge 8 commits into
devin-ai-integration[bot] wants to merge 8 commits into
Conversation
Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
… dependency Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration branch for four parallel workstreams (each landed as its own PR into this branch, then merged here in isolated-file-first order C → D → B → A):
softprops/action-gh-release@v1→@v2(v2 only moves the action runtime to Node 20;tag_name/filesunchanged).github/workflows/deploy.yml'API should be accessible'health test from the live backende2e/health.spec.ts.github/workflows/unit-tests.yml@angular/*→21.2.4+ ESLint (angular-eslint)package.json,bun.lock,eslint.config.js,angular.json, a fewsrc/**lint fixesTwo things worth knowing that aren't obvious from the diff:
zone.jswas missing entirely. Every spec starts withimport "zone.js", butzone.jsis only an optional peer of@angular/core, so it was never installed and the whole Vitest suite failed to even load (Failed to resolve import "zone.js"). Addingzone.js: ~0.16.0as a devDependency turns the suite from 6 failed files / 0 tests into 180 passing tests — which is also what makes the newunit-tests.ymlworkflow meaningful rather than red on day one.ESLint is deliberately non-blocking on pre-existing debt. Rather than refactoring app code to satisfy the recommended rulesets, the offending rules are switched off/downgraded in
eslint.config.jswith the reason inline:bun run linttherefore exits clean today (0 errors, 9 warnings) and can be tightened incrementally.The health test now intercepts instead of dialling out, and additionally asserts the app itself renders the mocked tags:
unit-tests.ymladds an explicitactions/setup-node@v4(node 22) step thatplaywright.ymldoesn't need:bunx vitesthitsERR_REQUIRE_ESMon Node < 20.19.Verification
Run on the integrated branch (Node 22.12.0 — the Angular CLI rejects the older Node that ships on the default image; see caveat below):
bun install— clean, no peer-dependency warningsbun run build— bundle generatedbun run test -- --run— 180 passed (6 files)bun run lint— 0 errors, 9 warningsbun run format:check— cleanbun run test:e2e:security— 16 passedbun run test:e2e— see belowbun run test:e2ehas pre-existing failures that also reproduce onmainbefore any of these changes (verified on the base commit): the 6settings.spec.tstests fail because the livePUT https://api.realworld.show/api/userreturns 422, andurl-navigation.spec.ts › tag paginationfails alongside them. These are live-backend/data issues, not regressions from this branch — and they are exactly the class of problem PR #54 removes for the health check.Caveat
package.jsondeclaresengines.node: >=20.11.1, but the Angular CLI now requires>=20.19 || >=22.12. Left unchanged here to keep the diff scoped; worth bumping in a follow-up.Link to Devin session: https://app.devin.ai/sessions/ea13f45ea5f64f718784d770acf9bddb
Requested by: @gaelkekatos-jpg
Devin Review