Skip to content

feature: Angular 21.2.4 + ESLint, Vitest CI workflow, gh-release v2, network-free health test - #55

Open
devin-ai-integration[bot] wants to merge 8 commits into
mainfrom
devin/1785137077-angular-upgrade-base
Open

devin-ai-integration[bot] wants to merge 8 commits into
mainfrom
devin/1785137077-angular-upgrade-base

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Summary

Integration branch for four parallel workstreams (each landed as its own PR into this branch, then merged here in isolated-file-first order C → D → B → A):

PR Scope Files
#51 softprops/action-gh-release@v1 → @v2 (v2 only moves the action runtime to Node 20; tag_name/files unchanged) .github/workflows/deploy.yml
#54 Decouple the 'API should be accessible' health test from the live backend e2e/health.spec.ts
#52 New Vitest CI workflow .github/workflows/unit-tests.yml
#53 All @angular/* → 21.2.4 + ESLint (angular-eslint) package.json, bun.lock, eslint.config.js, angular.json, a few src/** lint fixes

Two things worth knowing that aren't obvious from the diff:

zone.js was missing entirely. Every spec starts with import "zone.js", but zone.js is only an optional peer of @angular/core, so it was never installed and the whole Vitest suite failed to even load (Failed to resolve import "zone.js"). Adding zone.js: ~0.16.0 as a devDependency turns the suite from 6 failed files / 0 tests into 180 passing tests — which is also what makes the new unit-tests.yml workflow meaningful rather than red on day one.

ESLint is deliberately non-blocking on pre-existing debt. Rather than refactoring app code to satisfy the recommended rulesets, the offending rules are switched off/downgraded in eslint.config.js with the reason inline:

'@angular-eslint/prefer-inject': 'off',      // 42 constructor-injection sites; sweeping refactor
'@angular-eslint/no-output-native': 'off',   // renaming `click`/`toggle` outputs is a breaking API change
'@angular-eslint/template/alt-text': 'warn', // 9 pre-existing a11y gaps, tracked separately

bun run lint therefore exits clean today (0 errors, 9 warnings) and can be tightened incrementally.

The health test now intercepts instead of dialling out, and additionally asserts the app itself renders the mocked tags:

await page.route('https://api.realworld.show/api/tags', route => route.fulfill({ ... tags: ['angular','react','vue'] }));
await page.goto('/');
expect(routeHits).toBeGreaterThan(0);
await expect(page.locator('.sidebar .tag-list').getByText('angular')).toBeVisible();

unit-tests.yml adds an explicit actions/setup-node@v4 (node 22) step that playwright.yml doesn't need: bunx vitest hits ERR_REQUIRE_ESM on Node < 20.19.

Verification

Run on the integrated branch (Node 22.12.0 — the Angular CLI rejects the older Node that ships on the default image; see caveat below):

  • bun install — clean, no peer-dependency warnings
  • bun run build — bundle generated
  • bun run test -- --run — 180 passed (6 files)
  • bun run lint — 0 errors, 9 warnings
  • bun run format:check — clean
  • bun run test:e2e:security — 16 passed
  • bun run test:e2e — see below

bun run test:e2e has pre-existing failures that also reproduce on main before any of these changes (verified on the base commit): the 6 settings.spec.ts tests fail because the live PUT https://api.realworld.show/api/user returns 422, and url-navigation.spec.ts › tag pagination fails alongside them. These are live-backend/data issues, not regressions from this branch — and they are exactly the class of problem PR #54 removes for the health check.

Caveat

package.json declares engines.node: >=20.11.1, but the Angular CLI now requires >=20.19 || >=22.12. Left unchanged here to keep the diff scoped; worth bumping in a follow-up.

Link to Devin session: https://app.devin.ai/sessions/ea13f45ea5f64f718784d770acf9bddb
Requested by: @gaelkekatos-jpg


Devin Review

Status Commit
⚪ Not started —

Run Devin Review

Open in Devin Review (Staging)

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants