Repository navigation
bug: omit empty password from settings update payload - #56
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The settings form always sent password: '' when the user only changed
their bio or image, and the API rejects that with 422 ("password must be
a string between 8 and 128 chars"), so no profile update could succeed
without also setting a new password.
Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause of the 6
settings.spec.tse2e failures (pre-existing onmain, and the only thing keeping the Playwright gate red on #55).submitForm()posted the whole form, so a user who edited only their bio sentpassword: "":The backend rejects that outright — confirmed directly against the live API:
So no profile update could succeed unless the user also typed a new password. The e2e tests were correct; the app was wrong.
Targets the integration branch of #55 rather than
mainso the full gate can go green there.Verification
bunx playwright test e2e/settings.spec.ts→ 7 passed (was 6 failed / 1 passed).bun run build,bun run test -- --run(180 passed),bun run lint,bun run format:checkall clean.Note
passwordstill carriesValidators.required, which is now clearly wrong for an optional "New Password" field — left alone here to keep the diff to the actual bug, since nothing gates submission on form validity.Link to Devin session: https://app.devin.ai/sessions/ea13f45ea5f64f718784d770acf9bddb
Requested by: @gaelkekatos-jpg
Devin Review