Repository navigation
feature: ESLint, Vitest CI, gh-release v2, network-free health test (#55 without its Angular bump) - #87
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ealth test from #55, without its Angular bump
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| }); | ||
| }); | ||
|
|
||
| await page.goto('/'); |
Author
There was a problem hiding this comment.
🔍 Health check retains external network traffic
The page.goto('/') navigation still loads external stylesheets, and the homepage requests live articles. Mocking tags removes the direct API availability check, but does not make this test fully network-free.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#55 rebased onto the stack with its
@angular/*21.2.4 bump dropped (stack 2 of 2: #79 → #86 → this). Supersedes #55; #55 itself is left untouched, close it once this lands.Kept from #55, unchanged:
angular-eslint21.4.0,eslint10.7.0,typescript-eslint8.59.2,@eslint/js),eslint.config.js,ng linttarget,bun run lint,*.tslint-staged step, and the smallsrc/**lint fixes.github/workflows/unit-tests.yml(Vitest on push/PR)softprops/action-gh-release@v1→@v2indeploy.ymle2e/health.spec.tsmocks/api/tagsinstead of calling the live APIDropped: the
@angular/*21.2.4 bump andzone.jsadd (both already in #79 at 21.2.23 /~0.16.0).src/index.htmlkeeps #79's SRI/https:///langchanges (#55 never touched it).The settings empty-password fix (#56) is not stacked on this; it is its own PR off #79 so it can land independently.
Verification
bun run format:check: cleanbun run test -- --run: 180/180 passedbun run build: greenbun run lint: all files passDevin-Org: engineering
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop