Skip to content

feature: ESLint, Vitest CI, gh-release v2, network-free health test (#55 without its Angular bump) - #87

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/task-19-snyk-overrides-on-79from
devin/task-19-eslint-ci-on-overrides
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/task-19-snyk-overrides-on-79from
devin/task-19-eslint-ci-on-overrides

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

#55 rebased onto the stack with its @angular/* 21.2.4 bump dropped (stack 2 of 2: #79 → #86 → this). Supersedes #55; #55 itself is left untouched, close it once this lands.

Kept from #55, unchanged:

  • ESLint (angular-eslint 21.4.0, eslint 10.7.0, typescript-eslint 8.59.2, @eslint/js), eslint.config.js, ng lint target, bun run lint, *.ts lint-staged step, and the small src/** lint fixes
  • .github/workflows/unit-tests.yml (Vitest on push/PR)
  • softprops/action-gh-release@v1 → @v2 in deploy.yml
  • e2e/health.spec.ts mocks /api/tags instead of calling the live API

Dropped: the @angular/* 21.2.4 bump and zone.js add (both already in #79 at 21.2.23 / ~0.16.0). src/index.html keeps #79's SRI/https:///lang changes (#55 never touched it).

The settings empty-password fix (#56) is not stacked on this; it is its own PR off #79 so it can land independently.

Verification

  • bun run format:check: clean
  • bun run test -- --run: 180/180 passed
  • bun run build: green
  • bun run lint: all files pass

Devin-Org: engineering


Product Engineer opened this PR for Matthew
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedangular-eslint@​21.4.0991007394100
Addedtypescript-eslint@​8.59.21001007498100
Added@​angular-eslint/​builder@​21.4.01001007494100
Added@​eslint/​js@​10.0.110010010085100
Addedeslint@​10.7.09710010095100

View full report

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

Comment thread e2e/health.spec.ts
});
});

await page.goto('/');

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Health check retains external network traffic

The page.goto('/') navigation still loads external stylesheets, and the homepage requests live articles. Mocking tags removes the direct API availability check, but does not make this test fully network-free.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants