Repository navigation
bug: omit empty password from settings update payload (#56 retargeted off #55) - #88
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The settings form always sent password: '' when the user only changed
their bio or image, and the API rejects that with 422 ("password must be
a string between 8 and 128 chars"), so no profile update could succeed
without also setting a new password.
Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
Author
|
Browser verification against the live API on #88, plus #87 (which includes #86's dependency stack). Settings (#88)
|
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#56's single commit cherry-picked onto #79 so it no longer depends on #55's integration branch. Base is #79's branch for now; retarget to
mainonce #79 lands. Supersedes #56; #56 itself is left untouched, close it once this lands.submitForm()sent the whole form, so editing only the bio postedpassword: "", which the backend rejects with 422. Now:This matters for the #1258 (Spring Boot) settings flow: profile updates without a new password.
Verification
bun run format:check: cleanbun run test -- --run: 180/180 passedbun run build: greenDevin-Org: engineering
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop