Skip to content

bug: omit empty password from settings update payload (#56 retargeted off #55) - #88

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/1789994881-sonarqube-security-fixesfrom
devin/task-19-settings-empty-password-on-79
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/1789994881-sonarqube-security-fixesfrom
devin/task-19-settings-empty-password-on-79

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

#56's single commit cherry-picked onto #79 so it no longer depends on #55's integration branch. Base is #79's branch for now; retarget to main once #79 lands. Supersedes #56; #56 itself is left untouched, close it once this lands.

submitForm() sent the whole form, so editing only the bio posted password: "", which the backend rejects with 422. Now:

const { password, ...profile } = this.settingsForm.value;
this.userService.update(password ? { ...profile, password } : profile);

This matters for the #1258 (Spring Boot) settings flow: profile updates without a new password.

Verification

  • bun run format:check: clean
  • bun run test -- --run: 180/180 passed
  • bun run build: green

Devin-Org: engineering


Product Engineer opened this PR for Matthew
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop


The settings form always sent password: '' when the user only changed
their bio or image, and the API rejects that with 422 ("password must be
a string between 8 and 128 chars"), so no profile update could succeed
without also setting a new password.

Co-Authored-By: Gael Kekatos <gael.kekatos@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author

Browser verification against the live API on #88, plus #87 (which includes #86's dependency stack).

Settings (#88)

  • Fresh account registered (201).
  • Bio-only save with New Password blank: 200, bio shown on profile; actual PUT /api/user body had no password key.
  • New-password save included password, returned 200; logout + login with the new password worked, bio persisted.
Blank password before save Saved profile
Blank password Saved bio

Smoke (#87 / #86)

  • Live global feed, tag sidebar, article + comments and login render; ionicons render; no integrity/CSP or runtime console errors.
  • e2e/health.spec.ts: 4/4 pass.
Feed and tags Article and icons
Feed Article

#86 was checked through #87, not on its own. Recording

Written by Devin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants