Skip to content

Turret angle tolerance checking#100

Merged
skrunked merged 8 commits into
devfrom
feature/anti-slime
Jun 22, 2026
Merged

Turret angle tolerance checking#100
skrunked merged 8 commits into
devfrom
feature/anti-slime

Conversation

@skrunked

@skrunked skrunked commented May 29, 2026

Copy link
Copy Markdown
Contributor

Adds a new method to the Turret subsystem to check if the current angle is within tolerance, and a new command to the Uptake to run backwards when the turret is not in tolerance.

  • Tested in Sim
  • Tested on Robot

Closes #98.

skrunked added 2 commits May 28, 2026 23:57
…ally update uptake speed based on turret tolerance state. Untested, pushing to test off the MacBook.
@skrunked skrunked linked an issue Jun 19, 2026 that may be closed by this pull request
22 tasks
skrunked and others added 2 commits June 22, 2026 17:19
@skrunked skrunked marked this pull request as ready for review June 22, 2026 21:25
@skrunked skrunked requested a review from rxgran June 22, 2026 21:25

@rxgran rxgran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in line comments

Comment thread src/main/java/org/team157/robot/subsystems/turret/Turret.java Outdated
Comment thread src/main/java/org/team157/robot/subsystems/turret/Turret.java
Comment thread src/main/java/org/team157/robot/subsystems/turret/Turret.java
Comment thread src/main/java/org/team157/robot/subsystems/uptake/Uptake.java Outdated
Comment thread src/main/java/org/team157/robot/subsystems/uptake/Uptake.java Outdated
Comment thread src/main/java/org/team157/robot/subsystems/uptake/Uptake.java Outdated
@rxgran rxgran assigned skrunked and unassigned rxgran Jun 22, 2026
@rxgran rxgran self-requested a review June 22, 2026 23:34

@rxgran rxgran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrunked skrunked merged commit 09a2b16 into dev Jun 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Turret Angle Tolerance Checking

2 participants