Skip to content

fix(generation): refill catalog after birth-data hash change - #69

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-investigation-e552
Draft

cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-investigation-e552

Conversation

@cursor

@cursor cursor Bot commented Sep 3, 2026

Copy link
Copy Markdown

What changed

  • After a user changes birth data and clicks Generate, natal persist no longer treats previous-hash tool reports as complete.
  • Catalog fill (generate-catalog-batch) and Generate status now count only reports keyed to the current profileDataHash, so the remaining 40 tools regenerate instead of staying frozen on the old chart.
  • Clicking Generate again recovers profiles already stuck with mixed old/new reports.

Why this change is safe

  • Bug: PR feat(profile): persist every catalog report on Generate #68 (“persist every catalog report on Generate”) derives allReportsReady from summarizeToolReadiness without checking generationIdempotencyKey. Natal persist merges new Vedic/Western onto the previous catalog, sees 42 displayable reports, returns allReportsReady: true, and the Profile client skips catalog fill.
  • Trigger: User generates a full catalog, edits birth date/time/place, clicks Generate. Only natal charts rewrite; Tarot, numerology, and the rest stay computed for the old birth data. Ask the Seer then merges that stale catalog into prompts.
  • Fix: Optional current-hash argument on summarizeToolReadiness. Mismatched keys are pending; missing keys stay ready (legacy). Persist, catalog-batch, and generate-mystical GET/POST pass the live hash.
  • Scope is readiness + tests only. No billing, lock, or UI refactor. Distinct from open Fix stale tool reports after birth-data regeneration #53 (client display gating / field clearing): this PR unblocks the new fill pipeline so stale reports are actually regenerated.

Verification

  • pnpm exec eslint on touched files
  • pnpm test — 73 suites / 398 tests
  • pnpm run lint:security
  • Playwright smoke (API/readiness only; no UI/routing change)

Regression prevention

  • Readiness unit tests for hash mismatch vs missing key
  • generate-mystical POST fill_catalog + GET status when stored keys are stale
  • generate-catalog-batch generates hellenistic/esoteric instead of early-complete

Release checklist (solo-friendly)

  • CI green (Lint + Jest, Playwright smoke)
  • After merge: Generate on a profile with an existing catalog, change birth date, Generate again — remaining tools should refill instead of showing as complete immediately.
Open in Web View Automation 

Natal persist was counting previous-hash tool reports as ready, so Generate skipped catalog fill and left 40 tools keyed to the old birth data.

Co-authored-by: Andy Oliver Rozario <andyrozario7@gmail.com>
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
future-seer Ready Ready Preview Sep 3, 2026 11:14am UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant