fix(profile): do not delete stored reports on profile save - #74
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Profile Save always called /api/profile/invalidate-cache, which deleted
comprehensiveMysticalProfiles/{uid}. Cosmetic or note-only saves then wiped
every catalog reading while mysticalProfileGenerated and allReportsReady
stayed true, so Generate skipped and resume never refilled.
Co-authored-by: Andy Oliver Rozario <andyrozario7@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8 tasks
3 tasks
Owner
|
Superseded by #78 — unique fix cherry-picked onto current main (profile save no longer deletes stored reports). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
POST /api/profile/invalidate-cache, which deletedcomprehensiveMysticalProfiles/{uid}— every stored natal chart and catalog reading.mysticalProfileGeneratedorallReportsReady. After a non-hash save (for example a birth-time note), Generate treated the profile as already complete and catalog resume never ran, so the readings stayed gone.Why this change is safe
handleSaveon/profilealways hits invalidate-cache after a successful client write; the route used AdmindeleteDocumenton the comprehensive profile.hasOnly), and fix(generation): refill catalog after birth-data hash change #69/fix(generation): do not advance profile hash without natal regen #71 (hash/catalog persist).Verification
pnpm exec eslint app/api/profile/invalidate-cache/route.ts tests/integration/invalidate-cache.test.ts)pnpm test(74 suites / 396 tests)pnpm run lint:securitypnpm run securitystill fails on pre-existing high/critical advisories on main (next,sharp,js-yaml); not introduced here.Regression prevention
tests/integration/invalidate-cache.test.ts: authenticated call clears in-memory cache and must not calldeleteDocument.Release checklist (solo-friendly)
CI / Lint + JestCI / Playwright smokemainafter review.