fix(generation): do not advance profile hash without natal regen

[cursor]

What changed

• Catalog fill (generate-catalog-batch) and on-demand tool persist (ensure-tool-report) now return 409 when live birth fields no longer match the committed profileDataHash.
• persistOnDemandToolReports no longer writes profileDataHash unless natal charts already match that hash or this persist is rewriting Vedic/Western.

Why this change is safe

• Root cause identified: after PR feat(profile): persist every catalog report on Generate #68, an interrupted catalog fill plus a birth-data save (or opening a still-missing tool) computed a new hash from edited fields and stamped it on users / comprehensiveMysticalProfiles while natal reports kept the previous generationIdempotencyKey. isReportsStale then went false, so Vedic/Western showed the old chart with no regen prompt.
• Scope is focused (hash-commit helper, two persist callers, persist write guard, tests). No billing, auth, or Firestore rules changes.
• Risk areas reviewed: generate-mystical natal persist still writes the new hash because it rewrites vedic + western; unchanged-hash catalog fill is unchanged; complementary to open fix(generation): refill catalog after birth-data hash change #69 (skip-fill) and Fix stale tool reports after birth-data regeneration #53/Fix on-demand persist reverting profile hash after concurrent generate #57/Fix on-demand tool persist unlocking in-flight natal generate #58 (display/lock races), not a duplicate.

Bug and impact

A user who starts Generate, interrupts catalog fill, edits birth time, then returns to Profile (resume) or opens a tool without a report ends up with current-looking reports whose natal charts still describe the previous birth data. Ask the Seer and astrology tools treat that stale natal payload as authoritative.

Verification

• Changed-file ESLint (0 issues).
• plan-api-lib: lint:security passed; new unit + catalog-batch/ensure-tool-report 409 tests passed.
• plan-core: pnpm test — 74 suites / 401 tests.
• Playwright smoke run (API-only persist guard; no UI/routing changes).

Regression prevention

• Added profileHashCommit tests for committed vs live hash and natal key mismatch.
• Added API tests proving catalog batch and ensure-tool-report do not persist after a birth-data change.
• Existing generate-mystical / readiness / catalog-complete tests remain green.

Release checklist (solo-friendly)

• CI is green:
  • CI / Lint + Jest
  • CI / Playwright smoke
• Ready to merge to main.
• Post-merge sanity: interrupt catalog fill, change birth time, confirm resume asks to Generate and does not clear the stale state.

  

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
future-seer	Ready	Preview	Sep 6, 2026 11:14am UTC