fix(generation): do not overwrite real tool reports with placeholders

[cursor]

What changed

• Catalog fill, ensure-tool-report extraInputs, and overlapping Generate/tool-visit persists no longer replace a stored real reading with a placeholder: true payload.
• Stage B already had this keep-existing guard; persistOnDemandToolReports now matches it. First-time placeholders still persist when nothing real is stored, and sibling tools in the same batch still write.
• Automated critical-bug hunt (2026-09-08); not a user-filed issue.

Why this change is safe

• Root cause: persistOnDemandToolReports treated status: "success" + placeholder: true as a normal write. Palmistry (vision API failure), Feng Shui (analysis catch), and other orchestrator tools return success+placeholder instead of failed, so a later persist clobbered the real report.
• Concrete trigger: during Generate Full Report catalog fill, open Palmistry (or another tool still being generated). ensure-tool-report and a catalog batch can both persist; if the later write is a placeholder, the stored reading is destroyed. Feng Shui facingDirection extraInputs force-refresh has the same overwrite if generation returns a placeholder.
• Scope is the persist guard plus unit tests. No billing, auth, or natal-chart changes.
• Distinct from open Fix stale tool reports after birth-data regeneration #53/Fix on-demand persist reverting profile hash after concurrent generate #57/Fix on-demand tool persist unlocking in-flight natal generate #58 (stale hash / lock), fix(generation): refill catalog after birth-data hash change #69 (skip fill), fix(generation): do not advance profile hash without natal regen #71 (hash without natal), fix(generation): stop catalog fill spinning on placeholder tools #72 (placeholder exhaustion).

Verification

• pnpm exec eslint lib/onDemandToolReports.ts tests/unit/onDemandPlaceholderOverwrite.test.ts
• pnpm test — 74 suites / 400 tests passed
• pnpm run lint:security passed
• Playwright smoke run (persist-layer only; covered by unit + generate/ensure/catalog integration tests)
  • onboarding/profile/auth
  • special-user quota behavior (if relevant)

Regression prevention

• Added tests/unit/onDemandPlaceholderOverwrite.test.ts (would fail before this change: placeholder persist wrote palmistry onto the profile patch).
• Confirmed profile-generate, ensure-tool-report, generate-catalog-batch, report-readiness, and tool-visit tests remain green. Placeholders still write when no real report exists.

Release checklist (solo-friendly)

• CI is green:
  • CI / Lint + Jest
  • CI / Playwright smoke
• Ready to merge to main.
• Post-merge: during catalog fill, open Palmistry in another tab after a real reading is stored and confirm a later placeholder persist does not clear it.

  

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
future-seer	Ready	Preview	Sep 8, 2026 11:14am UTC